Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qtbase] Add support for building with OpenGL ES 3.0 #36407

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

fwcd
Copy link
Contributor

@fwcd fwcd commented Jan 27, 2024

This adds support for building Qt with OpenGL ES 3.0, a necessity to build many OpenGL apps for iOS.

Implementation note

The implementation follows the way the GL ES features are structured in the configure script, namely by implying gles2 and enabling gles3 only via a feature flag:

Checklist

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download (doesn't apply).
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file (doesn't apply).
  • Any patches that are no longer applied are deleted from the port's directory (doesn't apply).
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@fwcd fwcd mentioned this pull request Jan 27, 2024
54 tasks
@fwcd fwcd force-pushed the opengl-gles3 branch 2 times, most recently from cb630ec to 595cffd Compare January 27, 2024 16:09
@fwcd fwcd marked this pull request as ready for review January 27, 2024 22:41
@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 29, 2024
@jimwang118
Copy link
Contributor

This feature passed with following triplets:

x64-linux

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Jan 29, 2024
"name": "qtbase",
"default-features": false,
"features": [
"gles2"
Copy link
Contributor

@m-kuhn m-kuhn Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mention ios in the description, I had troubles building for ios with gles2 in the past (see https://codereview.qt-project.org/c/qt/qtbase/+/458413), is this issue solved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I could solve pretty much this exact issue by adding the gles3 feature.

@m-kuhn
Copy link
Contributor

m-kuhn commented Jan 29, 2024

FTR: gles is deprecated on iOS https://developer.apple.com/library/archive/documentation/3DDrawing/Conceptual/OpenGLES_ProgrammingGuide/AdoptingOpenGLES3/AdoptingOpenGLES3.html, so it's correct to not put this into default features.

@m-kuhn m-kuhn mentioned this pull request Jan 29, 2024
7 tasks
@data-queue
Copy link
Contributor

Can you resolve conflicts?

@jimwang118 jimwang118 removed the info:reviewed Pull Request changes follow basic guidelines label Jan 30, 2024
@jimwang118 jimwang118 marked this pull request as draft January 30, 2024 07:08
@fwcd fwcd marked this pull request as ready for review February 1, 2024 16:19
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Feb 2, 2024
@data-queue data-queue merged commit 69a6cce into microsoft:master Feb 2, 2024
16 checks passed
@fwcd fwcd deleted the opengl-gles3 branch February 2, 2024 20:07
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
fwcd added a commit to fwcd/vcpkg that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants