This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Fix serialport #982
Merged
Fix serialport #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilin-MS
requested review from
eriolchan,
dooriya,
xinyiz1226,
hellyzh,
JerryYangKai and
chagong
JerryYangKai
approved these changes
Mar 11, 2020
xinyiz1226
approved these changes
Mar 11, 2020
dooriya
approved these changes
Mar 11, 2020
eriolchan
approved these changes
Mar 19, 2020
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: issue 980: Unable to use serial port in VSCode (Insiders) Version: 1.43.0
Retire the entire
vendor/node-usb-native. Integrate with the latestserialport@8.0.6andusb-detection@4.6.0directly since they have supported the latestElectron v7and these two libs updates frequently.bug: Unable to use serial port in VSCode (Insiders) Version: 1.43.0
task: Integate latest serialport and usb-detection in Arduino
Update arduino extension's vscode engine requirement to
^v1.43.0.Update
tasks.jsonto v2.0.0 since v0.1.0 has been deprecated.Update fields in
package.jsonsince old fields are deprecated.TODO
After tested in different platform, decide whether or not to remove the serial port ending selection.
If current version works well in all platform: win, macOS, linux, then remove the ending option.