Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Fix Serial Monitor for VS Code 1.43.0 #267

Merged
merged 14 commits into from
Mar 19, 2020
Merged

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Mar 19, 2020

AB#34114

PLEASE TEST!!! Dependencies were a little flaky before so I want to make sure they're good now.

Description:

  • Uses "usb-native" npm package instead of "vendor/native-usb-native", which follows what the vscode-arduino team is doing in their PR (Fix serialport vscode-arduino#982)
  • Removed "vendor/native-usb-native"
  • Updated minimum version of VS Code to 1.43.0 to accommodate using "usb-native" package. In VS Code 1.43.0, they changed the electron version so the serial monitor fix we are using here does not work in older versions of VS Code (I tried with 1.42.0 and it didn't work)
    • VS Code auto updates to latest version

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested with a micro:bit
  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vandyliu vandyliu changed the title (WIP) Fix Serial Monitor for VS Code 1.43.0 Fix Serial Monitor for VS Code 1.43.0 Mar 19, 2020
Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job, really streamlined this part!
LGTM ✌️

src/serialPortControl.ts Show resolved Hide resolved
Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works :) Great to have the serial monitor back!

@vandyliu vandyliu merged commit e897b84 into dev Mar 19, 2020
@vandyliu vandyliu deleted the users/t-vali/serial-monitor-fix branch March 19, 2020 23:08
@vandyliu vandyliu mentioned this pull request Mar 27, 2020
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants