This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
Fixes associated with chrome launch tests #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
approved these changes
May 4, 2019
digeff
reviewed
May 6, 2019
| logger.verbose('[ConnectingCDA]: Attaching to an existing instance of debugee...'); | ||
| const attachArgs = <IAttachRequestArgs>this._configuration.args; | ||
| await this._chromeConnection.attach(attachArgs.address, attachArgs.port, attachArgs.url, attachArgs.timeout, attachArgs.extraCRDPChannelPort); | ||
| } |
There was a problem hiding this comment.
I'd add an else case and throw an exception or something if it's neither Launch or Attach (which should be impossible, yet I've seen impossible things happening in software before...)
digeff
approved these changes
May 6, 2019
This is the same bug that Rob reported here that deals with builds on windows using backslashes incorrectly: microsoft/vscode-nls#19
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to handle attach requests in ConnectingCDA, and updated vscode-nls-dev to fix windows path separator bug (this was breaking localization and causing the "messages not found" error).