Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After making a change to a PR that was made on a fork the "Files" tree is empty #3294

Closed
alexr00 opened this issue Feb 4, 2022 · 2 comments
Closed

After making a change to a PR that was made on a fork the "Files" tree is empty #3294

alexr00 opened this issue Feb 4, 2022 · 2 comments
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone
January 2022 Reco...

Comments

@alexr00
Copy link
Member

alexr00 commented Feb 4, 2022

image

Refreshing the tree doesn't bring the files back.
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Feb 4, 2022
@alexr00 alexr00 added this to the January 2022 Recovery milestone Feb 4, 2022
@alexr00 alexr00 self-assigned this Feb 4, 2022
alexr00 added a commit to alexr00/vscode-pull-request-github-1 that referenced this issue Feb 4, 2022
@alexr00
Try to reproduce microsoft#3294
d1de833
@alexr00 alexr00 mentioned this issue Feb 4, 2022
Closed
alexr00 added a commit that referenced this issue Feb 4, 2022
@alexr00
After making a change to a PR that was made on a fork the "Files" tre…
7398918 
…e is empty

Part of  #3294
This was referenced Feb 4, 2022
Merged
Closed
@alexr00 alexr00 modified the milestones: January 2022 Recovery, January 2022 Recovery 1 Feb 9, 2022
@alexr00 alexr00 mentioned this issue Feb 9, 2022
Merged
alexr00 added a commit that referenced this issue Feb 10, 2022
@alexr00
After making a change to a PR that was made on a fork the "Files" tre…
01b5fdd 
…e is empty (#3296) (#3307)

Fixes #3294
@alexr00 alexr00 closed this as completed Feb 10, 2022
@alexr00
Copy link
Member Author

alexr00 commented Feb 10, 2022 •
edited
Loading

To verify (you MUST use VS Code desktop for part of this, but it's ok to start in vscode.dev or github.dev if you want):

  1. Find a repository that you don't own that you have commit rights too. We'll call this upstream.
  2. Make a fork of upstream. We'll call this fork.
  3. Make a PR from fork into upstream. The change should include 3+ files.

From here on out, you must use VS Code desktop

  1. Open the upstream repo in VS Code.
  2. Make sure you have the pre-release version of GHPRI.
  3. From the "Pull Requests" view, checkout the PR you made in step 3.
  4. Make a change to all of the files in the PR. Commit and push the change to the PR.
  5. Open the "Change in Pull Request" view. Verify that the "Files" subtree has the correct children.

@aeschli
Copy link
Contributor

aeschli commented Feb 10, 2022

Verified with PR extension running on resources from Github Repositories.

@aeschli aeschli added the verified Verification succeeded label Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
January 2022 Recovery 1
Development

No branches or pull requests
2 participants
@aeschli @alexr00