Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty files tree #3307

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Fix empty files tree #3307

merged 1 commit into from
Feb 10, 2022

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Feb 9, 2022

Fixes #3294

if (existingNode && (existingNode.pullRequestModel === pullRequestModel)) {
return;
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, the pull request node would get re-added to the tree view, but the old node wouldn't get disposed of. This led to tree nodes that didn't exist in the tree any more trying to refresh themselves, which in turn let to exceptions that prevented the tree from completing it's refresh.

@alexr00 alexr00 merged commit 01b5fdd into release/0.36 Feb 10, 2022
@alexr00 alexr00 deleted the alexr00/emptyFiles branch February 10, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants