Fix scrolling #11681
Merged
Fix scrolling #11681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidKutu
approved these changes
May 7, 2020
| public componentWillReceiveProps(prevProps: IContentPanelProps) { | ||
| // Scroll if we suddenly finished or updated a cell. This should happen on | ||
| // finish, updating output, etc. | ||
| if (!fastDeepEqual(prevProps.cellVMs, this.props.cellVMs)) { |
There was a problem hiding this comment.
Wouldn't it just be output updates where we would want to scroll to the bottom? Or is that trying to get too specific?
There was a problem hiding this comment.
Ah good catch. Expanding Collapsing input cause it to scroll too. We really only want output updates.
There was a problem hiding this comment.
Yeah, there is a lot of other stuff in cellVMs
|
Kudos, SonarCloud Quality Gate passed!
|
IanMatthewHuff
approved these changes
May 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #11681 +/- ##
==========================================
- Coverage 60.67% 60.66% -0.01%
==========================================
Files 627 628 +1
Lines 33879 33892 +13
Branches 4765 4769 +4
==========================================
+ Hits 20556 20562 +6
- Misses 12331 12335 +4
- Partials 992 995 +3
Continue to review full report at Codecov.
|
rchiodo
added a commit
that referenced
this pull request
May 8, 2020
* Fix scrolling * Review feedback - fix scrolling on expand/collapse
greazer
added a commit
that referenced
this pull request
May 8, 2020
* Fix scrolling (#11681) * Fix scrolling * Review feedback - fix scrolling on expand/collapse * Update changelog * Update package.json Co-authored-by: Jim Griesmer <jimgries@microsoft.com>
karthiknadig
added a commit
that referenced
this pull request
May 19, 2020
* Revert vscode-extension-telemetry changes for the release (#11602) (#11656) * Revert "Fix slashes in telemetry unit tests (#11572)" This reverts commit 7431c9c. * Revert "Use vscode-extension-telemetry for our exceptions & error telemetry (#11524)" This reverts commit d5065e6. * Remove from changelog * Port storage fix to release branch (#11673) * Fix storage not being used (#11649) * Fix storage not being used * Add disposable to storage so it won't write after shutdown * Fix dirty title * Hack to get tests to pass * Another way to get run all to not interfere * Update changelog * Port scrolling fix to release (#11688) * Fix scrolling (#11681) * Fix scrolling * Review feedback - fix scrolling on expand/collapse * Update changelog * Update package.json Co-authored-by: Jim Griesmer <jimgries@microsoft.com> * Cherry-pick pipenv changes and pythonpath prompt changes to release (#11700) * Show the prompt again if user clicks on more info (#11664) * Show the prompt again if user clicks on more info * Review feedback * Use Learn more as text for the link. * Leave pipenv in a corner until the user decides to select an interpreter (#11654) * add onSuggestion option * Swap onActivation with onSuggestion * Update unit tests * Remove registration of IPipenvService * Move didTriggerInterpreterSuggestions logic inside pipenv locator * Fix existing unit tests * Add new unit tests * Replace typemoq any param with object * Shorten the tests * Fix warning * Duplicate teardown Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Update extension version (#11730) * Update extension version * Update date in changelog. * Update change log with additional notes. (#11764) * Cherry picks and version updates for bug fix release (#11878) * Do not execute shebang as an interpreter until user has clicked on the codelens enclosing the shebang (#11816) * Do not execute shebang as an interpreter until user has clicked on the codelens enclosing the shebang * Rename * Oops * Update src/test/providers/shebangCodeLenseProvider.unit.test.ts Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com> * Update version and change log for bugfix release Co-authored-by: Kartik Raj <karraj@microsoft.com> * Clean up news Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> Co-authored-by: Jim Griesmer <jimgries@microsoft.com> Co-authored-by: Kartik Raj <karraj@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #11554
ContentPanel was scrolling on every update. We really only need to scroll when the cell vms change.
Also added the setting 'alwaysScrollOnNewCell' such that if a new cell is run, we will auto scroll to the bottom in the interactive window.