rewrite video src links (#920)

fixes #780
microsoft · Dec 15, 2023 · b18c620 · b18c620
1 parent 916fd91
commit b18c620
Show file tree

Hide file tree

Showing 12 changed files with 23 additions and 1 deletion.
diff --git a/src/package.ts b/src/package.ts
@@ -778,7 +778,7 @@ export abstract class MarkdownProcessor extends BaseProcessor {
 			contents = contents.replace(markdownPathRegex, urlReplace);
 
 			// Replace <img> links with urls
-			contents = contents.replace(/<img[^>]+src=["']([/.\w\s#-]+)['"][^>]*>/gm, (all, link) => {
+			contents = contents.replace(/<(?:img|video)[^>]+src=["']([/.\w\s#-]+)['"][^>]*>/gm, (all, link) => {
 				const isLinkRelative = !/^\w+:\/\//.test(link) && link[0] !== '#';
 
 				if (!this.baseImagesUrl && isLinkRelative) {

diff --git a/src/test/fixtures/readme/readme.branch.main.expected.md b/src/test/fixtures/readme/readme.branch.main.expected.md
@@ -25,6 +25,8 @@ The status bar lets you quickly navigate to any issue and you can see all positi
 ![](https://github.com/username/repository/raw/main/SpellMDDemo2.gif#gh-light-mode-only)
 <img src="https://github.com/username/repository/raw/main/images/myImage.gif">
 <img src="https://github.com/username/repository/raw/main/images/myImage.gif#gh-light-mode-only">
+<video src="https://github.com/username/repository/raw/main/videos/myVideo.mp4"></video>
+<video src="https://github.com/username/repository/raw/main/videos/myVideo.mp4#gh-light-mode-only"></video>
 
 The `spellMD.json` config file is watched so you can add more ignores or change mappings at will.
 

diff --git a/src/test/fixtures/readme/readme.branch.override.content.expected.md b/src/test/fixtures/readme/readme.branch.override.content.expected.md
@@ -25,6 +25,8 @@ The status bar lets you quickly navigate to any issue and you can see all positi
 ![](https://github.com/base/SpellMDDemo2.gif#gh-light-mode-only)
 <img src="https://github.com/base/images/myImage.gif">
 <img src="https://github.com/base/images/myImage.gif#gh-light-mode-only">
+<video src="https://github.com/base/videos/myVideo.mp4"></video>
+<video src="https://github.com/base/videos/myVideo.mp4#gh-light-mode-only"></video>
 
 The `spellMD.json` config file is watched so you can add more ignores or change mappings at will.
 

diff --git a/src/test/fixtures/readme/readme.branch.override.images.expected.md b/src/test/fixtures/readme/readme.branch.override.images.expected.md
@@ -25,6 +25,8 @@ The status bar lets you quickly navigate to any issue and you can see all positi
 ![](https://github.com/base/SpellMDDemo2.gif#gh-light-mode-only)
 <img src="https://github.com/base/images/myImage.gif">
 <img src="https://github.com/base/images/myImage.gif#gh-light-mode-only">
+<video src="https://github.com/base/videos/myVideo.mp4"></video>
+<video src="https://github.com/base/videos/myVideo.mp4#gh-light-mode-only"></video>
 
 The `spellMD.json` config file is watched so you can add more ignores or change mappings at will.
 

diff --git a/src/test/fixtures/readme/readme.default.md b/src/test/fixtures/readme/readme.default.md
@@ -25,6 +25,8 @@ The status bar lets you quickly navigate to any issue and you can see all positi
 ![](https://github.com/username/repository/raw/HEAD/SpellMDDemo2.gif#gh-light-mode-only)
 <img src="https://github.com/username/repository/raw/HEAD/images/myImage.gif">
 <img src="https://github.com/username/repository/raw/HEAD/images/myImage.gif#gh-light-mode-only">
+<video src="https://github.com/username/repository/raw/HEAD/videos/myVideo.mp4"></video>
+<video src="https://github.com/username/repository/raw/HEAD/videos/myVideo.mp4#gh-light-mode-only"></video>
 
 The `spellMD.json` config file is watched so you can add more ignores or change mappings at will.
 

diff --git a/src/test/fixtures/readme/readme.expected.md b/src/test/fixtures/readme/readme.expected.md
@@ -25,6 +25,8 @@ The status bar lets you quickly navigate to any issue and you can see all positi
 ![](https://github.com/username/repository/raw/master/SpellMDDemo2.gif#gh-light-mode-only)
 <img src="https://github.com/username/repository/raw/master/images/myImage.gif">
 <img src="https://github.com/username/repository/raw/master/images/myImage.gif#gh-light-mode-only">
+<video src="https://github.com/username/repository/raw/master/videos/myVideo.mp4"></video>
+<video src="https://github.com/username/repository/raw/master/videos/myVideo.mp4#gh-light-mode-only"></video>
 
 The `spellMD.json` config file is watched so you can add more ignores or change mappings at will.
 

diff --git a/src/test/fixtures/readme/readme.gitlab.branch.main.expected.md b/src/test/fixtures/readme/readme.gitlab.branch.main.expected.md
@@ -25,6 +25,8 @@ The status bar lets you quickly navigate to any issue and you can see all positi
 ![](https://gitlab.com/username/repository/-/raw/main/SpellMDDemo2.gif#gh-light-mode-only)
 <img src="https://gitlab.com/username/repository/-/raw/main/images/myImage.gif">
 <img src="https://gitlab.com/username/repository/-/raw/main/images/myImage.gif#gh-light-mode-only">
+<video src="https://gitlab.com/username/repository/-/raw/main/videos/myVideo.mp4"></video>
+<video src="https://gitlab.com/username/repository/-/raw/main/videos/myVideo.mp4#gh-light-mode-only"></video>
 
 The `spellMD.json` config file is watched so you can add more ignores or change mappings at will.
 

diff --git a/src/test/fixtures/readme/readme.gitlab.branch.override.content.expected.md b/src/test/fixtures/readme/readme.gitlab.branch.override.content.expected.md
@@ -25,6 +25,8 @@ The status bar lets you quickly navigate to any issue and you can see all positi
 ![](https://gitlab.com/base/SpellMDDemo2.gif#gh-light-mode-only)
 <img src="https://gitlab.com/base/images/myImage.gif">
 <img src="https://gitlab.com/base/images/myImage.gif#gh-light-mode-only">
+<video src="https://gitlab.com/base/videos/myVideo.mp4"></video>
+<video src="https://gitlab.com/base/videos/myVideo.mp4#gh-light-mode-only"></video>
 
 The `spellMD.json` config file is watched so you can add more ignores or change mappings at will.
 

diff --git a/src/test/fixtures/readme/readme.gitlab.branch.override.images.expected.md b/src/test/fixtures/readme/readme.gitlab.branch.override.images.expected.md
@@ -25,6 +25,8 @@ The status bar lets you quickly navigate to any issue and you can see all positi
 ![](https://gitlab.com/base/SpellMDDemo2.gif#gh-light-mode-only)
 <img src="https://gitlab.com/base/images/myImage.gif">
 <img src="https://gitlab.com/base/images/myImage.gif#gh-light-mode-only">
+<video src="https://gitlab.com/base/videos/myVideo.mp4"></video>
+<video src="https://gitlab.com/base/videos/myVideo.mp4#gh-light-mode-only"></video>
 
 The `spellMD.json` config file is watched so you can add more ignores or change mappings at will.
 

diff --git a/src/test/fixtures/readme/readme.gitlab.default.md b/src/test/fixtures/readme/readme.gitlab.default.md
@@ -25,6 +25,8 @@ The status bar lets you quickly navigate to any issue and you can see all positi
 ![](https://gitlab.com/username/repository/-/raw/HEAD/SpellMDDemo2.gif#gh-light-mode-only)
 <img src="https://gitlab.com/username/repository/-/raw/HEAD/images/myImage.gif">
 <img src="https://gitlab.com/username/repository/-/raw/HEAD/images/myImage.gif#gh-light-mode-only">
+<video src="https://gitlab.com/username/repository/-/raw/HEAD/videos/myVideo.mp4"></video>
+<video src="https://gitlab.com/username/repository/-/raw/HEAD/videos/myVideo.mp4#gh-light-mode-only"></video>
 
 The `spellMD.json` config file is watched so you can add more ignores or change mappings at will.
 

diff --git a/src/test/fixtures/readme/readme.images.expected.md b/src/test/fixtures/readme/readme.images.expected.md
@@ -25,6 +25,8 @@ The status bar lets you quickly navigate to any issue and you can see all positi
 ![](https://github.com/username/repository/path/to/SpellMDDemo2.gif#gh-light-mode-only)
 <img src="https://github.com/username/repository/path/to/images/myImage.gif">
 <img src="https://github.com/username/repository/path/to/images/myImage.gif#gh-light-mode-only">
+<video src="https://github.com/username/repository/path/to/videos/myVideo.mp4"></video>
+<video src="https://github.com/username/repository/path/to/videos/myVideo.mp4#gh-light-mode-only"></video>
 
 The `spellMD.json` config file is watched so you can add more ignores or change mappings at will.
 

diff --git a/src/test/fixtures/readme/readme.md b/src/test/fixtures/readme/readme.md
@@ -25,6 +25,8 @@ The status bar lets you quickly navigate to any issue and you can see all positi
 ![](./SpellMDDemo2.gif#gh-light-mode-only)
 <img src="/images/myImage.gif">
 <img src="/images/myImage.gif#gh-light-mode-only">
+<video src="/videos/myVideo.mp4"></video>
+<video src="/videos/myVideo.mp4#gh-light-mode-only"></video>
 
 The `spellMD.json` config file is watched so you can add more ignores or change mappings at will.