Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite video tags on publish #780

Closed
mjbvz opened this issue Oct 21, 2022 · 0 comments · Fixed by #920
Closed

Rewrite video tags on publish #780

mjbvz opened this issue Oct 21, 2022 · 0 comments · Fixed by #920
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Oct 21, 2022

From microsoft/vsmarketplace#494
For microsoft/vscode#134514

When publishing an extension readme, we supported rewriting relative image paths to absolute paths that the marketplace and VS Code can resolve. We should do the same for videos

This test extension demonstrates the issue. The markdown in the readme is:

Local video:

<video src="test.mp4"></video>

Local Image: 

<img src="cat.gif">

Remote video:

<video src="https://github.com/mjbvz/test-vscode-ext/raw/main/test.mp4"></video>

Unlike the <img> tags, the first video's src does not get correctly rewritten to point to the extension's GitHub repo

@joaomoreno joaomoreno self-assigned this Oct 21, 2022
@joaomoreno joaomoreno added the help wanted Issues identified as good community contribution opportunities label Oct 21, 2022
@joaomoreno joaomoreno added feature-request Request for new features or functionality and removed help wanted Issues identified as good community contribution opportunities labels Dec 15, 2023
@joaomoreno joaomoreno added this to the December / January 2024 milestone Dec 15, 2023
joaomoreno added a commit that referenced this issue Dec 15, 2023
joaomoreno added a commit that referenced this issue Dec 15, 2023
@joaomoreno joaomoreno added the verification-needed Verification of issue is requested label Jan 23, 2024
@connor4312 connor4312 added the verified Verification succeeded label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants