Explore improving search performance to support high maxResults

[jrieken]

extracted from #8563 (comment)

• open vscode repo
• have "search.maxResults": 200000000
• search for ;
• 🐌 notice how VS Code becomes slower and slower... I can see that each call to refreshAndUpdateCount takes close to 1 second and these calls happen repeatedly

[roblourens]

I was investigating slowness in the search process, actually i didn't notice that the tree does slow down at some point. I never see the window totally stop responding though, just slow. Is there anything I can do differently @joaomoreno?

Maybe I should set a 200k limit on that setting for now

[jrieken]

I never see the window totally stop responding though, just slow

Me neither... It is not a full freeze but reaches a point where things aren't very usable anymore

[roblourens]

With the diffIdentityProvider, much improved:

Thanks for the tip @connor4312. And there are other easy optimizations to make on my end. With this many results, we can render less often or not at all. Nobody will read through 300,000 results, but we can keep them in the model for a replace.

[roblourens]

That is good enough that I'll call it a fix, but I will look at it again with #127038

[chrmarti]

Reverting the commit because it broke the smoke tests.

[roblourens]

Not brave enough to make the needed changes for this release. Thanks @chrmarti