-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Acc] Button tooltip doesn't show up on tab\ #132344
Comments
@isidorn , Hey, I search to see if there is something already open but couldn't find it. I hope it is not a duplicate. |
GitHubTags:#A11yMAS;#A11yTCS;#Win32;#DesktopApp;#A11y_VSCode;#WCAG1.3.3;#A11ySev3;#VisualStudioCode-Win32-Apr2021;#Benchmark;#Visual Studio Code Client;#Keyboard;#CEACCReviewed; |
Removing |
Hi @isidorn , we met the same issue. In our Teams Toolkit extension, we have several buttons on tree items. When user tab to the buttons with keyboard, tooltip will not show: |
This can be closed when #154364 happens |
Ben has adopted the custom hover in our base widgets, so this may now be easier than before? |
Kai mentioned I should consider adding a delay like we have for mouse hovers here. I need to see if this is acceptable by accessibility standards. |
AFAICT, the WAI-ARIA guidelines do not specify that there cannot be a delay. |
@benibenj it seems like this already works thanks to your changes button.mov |
When I tested on native Windows explorer, I saw a delay even when using keyboard, so it seems the same delay should apply for keyboard and mouse. |
Currently the mouse and keyboard delays are exactly the same which is what we want. We do not have delays where we support instant hover such as navigating between action items on a toolbar/actionbar. FYI: pressing |
@benibenj awesome work! |
Does this issue occur when all extensions are disabled?: Yes
Steps to Reproduce:
Expected : On the tab navigation to each of the button, the tooltip should be displayed. On escape the tooltip should be dismissed. Keyboard users will not know what is the use of the button through the icon for the button.
Actual : User cannot see the tooltip when they tab into a button. They can only see the tooltip when they hover over.
The text was updated successfully, but these errors were encountered: