Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Acc] Button tooltip doesn't show up on tab\ #132344

Closed
setaskin opened this issue Sep 4, 2021 · 27 comments · Fixed by #197965 or #199220
Closed

[Acc] Button tooltip doesn't show up on tab\ #132344

setaskin opened this issue Sep 4, 2021 · 27 comments · Fixed by #197965 or #199220
Assignees
Labels
a11y-partner Accessibility issue that a parter team is depending on a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality on-testplan workbench-hover Hover issues in the workbench
Milestone

Comments

@setaskin
Copy link

setaskin commented Sep 4, 2021

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.60.0 (user setup)
  • OS Version: Windows 10

Steps to Reproduce:

  1. Navigate through VS Code Search tab and tab through all the buttons . ( refresh , clear search results , etc. ) ( Search tab is just an example I can see the same behavior in all buttons)

Expected : On the tab navigation to each of the button, the tooltip should be displayed. On escape the tooltip should be dismissed. Keyboard users will not know what is the use of the button through the icon for the button.

Actual : User cannot see the tooltip when they tab into a button. They can only see the tooltip when they hover over.
Animation2

@setaskin
Copy link
Author

setaskin commented Sep 4, 2021

@isidorn , Hey, I search to see if there is something already open but couldn't find it. I hope it is not a duplicate.

@isidorn isidorn self-assigned this Sep 6, 2021
@isidorn isidorn added a11y-partner Accessibility issue that a parter team is depending on accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality labels Sep 6, 2021
@isidorn isidorn added this to the Backlog milestone Sep 6, 2021
@isidorn
Copy link
Contributor

isidorn commented Sep 6, 2021

Dup of #52016
Reasons why we are not changing this still hold which I mentioned here

Leaving this open for tracking purposes.

@fsteffi
Copy link

fsteffi commented Sep 20, 2021

GitHubTags:#A11yMAS;#A11yTCS;#Win32;#DesktopApp;#A11y_VSCode;#WCAG1.3.3;#A11ySev3;#VisualStudioCode-Win32-Apr2021;#Benchmark;#Visual Studio Code Client;#Keyboard;#CEACCReviewed;

@isidorn isidorn added the accessibility-sla Accessibility issue which have to be fixed or lowered severity based on process label Oct 14, 2021
@isidorn
Copy link
Contributor

isidorn commented Oct 18, 2021

Removing accessibility-sla label because we got confirmation from the testing team that this can be moved to Severity 3.
Reasoning why this is Severity 3 can be found here

@isidorn isidorn removed the accessibility-sla Accessibility issue which have to be fixed or lowered severity based on process label Oct 18, 2021
@isidorn isidorn added the a11ymas Issue from accessibility team label Jan 28, 2022
@HuihuiWu-Microsoft
Copy link

Hi @isidorn , we met the same issue. In our Teams Toolkit extension, we have several buttons on tree items. When user tab to the buttons with keyboard, tooltip will not show:
image
Accessibility team has raised a Sev2 bug to us for this issue. Is it possible to fix this?

@meganrogge meganrogge added this to the December 2023 milestone Nov 27, 2023
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Nov 27, 2023
@meganrogge meganrogge reopened this Nov 27, 2023
@vscodenpa vscodenpa removed the unreleased Patch has not yet been released in VS Code Insiders label Nov 27, 2023
@meganrogge
Copy link
Contributor

This can be closed when #154364 happens

@bpasero
Copy link
Member

bpasero commented Feb 16, 2024

Ben has adopted the custom hover in our base widgets, so this may now be easier than before?

@meganrogge meganrogge modified the milestones: February 2024, March 2024 Feb 16, 2024
@meganrogge
Copy link
Contributor

Kai mentioned I should consider adding a delay like we have for mouse hovers here. I need to see if this is acceptable by accessibility standards.

@meganrogge
Copy link
Contributor

AFAICT, the WAI-ARIA guidelines do not specify that there cannot be a delay.

@meganrogge
Copy link
Contributor

@benibenj it seems like this already works thanks to your changes

button.mov

@bpasero
Copy link
Member

bpasero commented Mar 7, 2024

When I tested on native Windows explorer, I saw a delay even when using keyboard, so it seems the same delay should apply for keyboard and mouse.

@benibenj
Copy link
Contributor

benibenj commented Mar 7, 2024

Currently the mouse and keyboard delays are exactly the same which is what we want. We do not have delays where we support instant hover such as navigating between action items on a toolbar/actionbar.

FYI: pressing ESC closes the hover

@isidorn
Copy link
Contributor

isidorn commented Mar 7, 2024

@benibenj awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-partner Accessibility issue that a parter team is depending on a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality on-testplan workbench-hover Hover issues in the workbench
Projects
None yet