-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Acc] Keyboard accessible tooltips- Fixes #132344 #197965
Conversation
Ensures some elements with tabindex=-1 have the title attribute (breadcrumbs and the editor title toolbar), allowing keyboard accessible tooltips
Thank you so much for looking into this. I am still not seeing it work - what am I doing wrong here? Edit: I see you said you've tested this on Windows. I'm seeing different behavior probably because I'm using mac. Screen.Recording.2023-11-10.at.2.14.16.PM.mov |
Well that definitely explains it! Not surprising the Edge team never tested the feature on a Mac. I tried to use a web based gif capture tool but it wasn't able to capture the tooltips. |
This works well on windows for some of the buttons @r3m0t . Thanks for working on it. Is it ready for review or still a wip? |
I think we should merge this since it fixes some cases. |
I think this should be behind a runtime flag mainly because the changes are incomplete in upstream, refs comment https://bugs.chromium.org/p/chromium/issues/detail?id=829352#c45 . @meganrogge it would be good to know what work is remaining to enable it by default from the edge team. |
@deepak1556 do we have an edge contact? |
I imagine putting it behind a runtime flag will mean almost no users see the change. Should we instead wait until it's fixed upstream? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on enabling the runtime feature flag.
Revert "Merge pull request microsoft#197965 from r3m0t/selfish-crawdad"
Enables the Blink feature keyboard accessible tooltips
Ensures some elements with tabindex=-1 have the title attribute (breadcrumbs and the editor title toolbar), allowing keyboard accessible tooltips
Fixes #132344
I navigate with the keyboard and see tooltips in the breadcrumb and the editor title (Split Editor Right) and the layout toggles (Toggle Panel)
However, when using the mouse, some things have double tooltips like the layout toggles.