Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show tooltip on icon label keyboard focus #199220

Merged
merged 2 commits into from
Nov 27, 2023
Merged

show tooltip on icon label keyboard focus #199220

merged 2 commits into from
Nov 27, 2023

Conversation

meganrogge
Copy link
Contributor

Will only work for icon labels with custom hovers

partially fix #132344

@meganrogge meganrogge requested a review from Tyriar November 27, 2023 20:34
@meganrogge meganrogge self-assigned this Nov 27, 2023
@meganrogge meganrogge added this to the November 2023 milestone Nov 27, 2023
@meganrogge meganrogge requested a review from Tyriar November 27, 2023 20:53
Tyriar
Tyriar approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this gets a TPI/verification as it looks like main issue won't be closed with this.

@meganrogge
Copy link
Contributor Author

#199228

@meganrogge meganrogge enabled auto-merge November 27, 2023 21:09
@meganrogge meganrogge merged commit fccd478 into main Nov 27, 2023
6 checks passed
@meganrogge meganrogge deleted the merogge/tooltip-on-keyboard-focus branch November 27, 2023 21:10
@meganrogge meganrogge mentioned this pull request Nov 28, 2023
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.

[Acc] Button tooltip doesn't show up on tab\
2 participants
@meganrogge @Tyriar