-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeline: Codicons are off #160060
Comments
I assume this is nothing to do with the views instead its about how entires are rendered in list/tree. CC @joaomoreno |
@sandy081 Tree row contents are outside of the tree's jurisdiction, but are in fact responsibility of the widget user. |
Timeline doesn't use the extension tree view and instead does it's own thing. I think @lramos15 works on timeline. |
@daviddossett curious, do we have an understanding what caused this? it seems relatively recent? |
@lramos15 it looks like timeline relies on the custom tree view css. I made a change in the nesting/ordering of elements in the tree view recently and I updated the css to reflect that. Because timeline relies on the css but doesn't actually use the custom tree view, this broke the timeline. I've opened a PR with a timeline specific css fix. |
* Closely align custom tree decorations to explorer * Timeline: Codicons are off Fixes #160060
Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting |
//cc @sandy081 @alexr00 for views
The text was updated successfully, but these errors were encountered: