Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline: Codicons are off #160060

Closed
bpasero opened this issue Sep 5, 2022 · 8 comments · Fixed by #160212 or #160797
Closed

Timeline: Codicons are off #160060

bpasero opened this issue Sep 5, 2022 · 8 comments · Fixed by #160212 or #160797
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue verified Verification succeeded workbench-views Workbench view issues

Comments

@bpasero
Copy link
Member

bpasero commented Sep 5, 2022

image

//cc @sandy081 @alexr00 for views

@sandy081
Copy link
Member

sandy081 commented Sep 5, 2022

I assume this is nothing to do with the views instead its about how entires are rendered in list/tree. CC @joaomoreno

@joaomoreno
Copy link
Member

joaomoreno commented Sep 5, 2022

@sandy081 Tree row contents are outside of the tree's jurisdiction, but are in fact responsibility of the widget user.

@alexr00
Copy link
Member

alexr00 commented Sep 5, 2022

Timeline doesn't use the extension tree view and instead does it's own thing. I think @lramos15 works on timeline.

@bpasero bpasero added the timeline Timeline view issues label Sep 5, 2022
@lramos15 lramos15 added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue labels Sep 6, 2022
@miguelsolorio miguelsolorio removed their assignment Sep 6, 2022
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Sep 7, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the September 2022 milestone Sep 7, 2022
@bpasero
Copy link
Member Author

bpasero commented Sep 7, 2022

@daviddossett curious, do we have an understanding what caused this? it seems relatively recent?

@daviddossett
Copy link
Contributor

Might be related to #158250. @benibenj any ideas here?

@bpasero
Copy link
Member Author

bpasero commented Sep 7, 2022

It was caused by dffbdeb, @alexr00 can you check? I see a visual difference not only with the alignment but also the spacing:

Before
image

After
image

@bpasero bpasero reopened this Sep 7, 2022
@bpasero bpasero assigned alexr00 and unassigned lramos15 Sep 7, 2022
@VSCodeTriageBot VSCodeTriageBot removed the unreleased Patch has not yet been released in VS Code Insiders label Sep 7, 2022
@bpasero bpasero added workbench-views Workbench view issues unreleased Patch has not yet been released in VS Code Insiders and removed timeline Timeline view issues labels Sep 7, 2022
alexr00 added a commit that referenced this issue Sep 13, 2022
@alexr00
Copy link
Member

alexr00 commented Sep 13, 2022

@lramos15 it looks like timeline relies on the custom tree view css. I made a change in the nesting/ordering of elements in the tree view recently and I updated the css to reflect that. Because timeline relies on the css but doesn't actually use the custom tree view, this broke the timeline. I've opened a PR with a timeline specific css fix.

alexr00 added a commit that referenced this issue Sep 13, 2022
* Closely align custom tree decorations to explorer

* Timeline: Codicons are off
Fixes #160060
@VSCodeTriageBot VSCodeTriageBot removed the unreleased Patch has not yet been released in VS Code Insiders label Sep 13, 2022
@VSCodeTriageBot
Copy link
Collaborator

Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting \closedWith someCommitSha, or directly add the insiders-released label if you know this has already been releaased

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 13, 2022
@bpasero bpasero added the verified Verification succeeded label Sep 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue verified Verification succeeded workbench-views Workbench view issues
Projects
None yet
8 participants