Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional TreeItem Checkbox #158250

Merged
merged 16 commits into from
Sep 6, 2022
Merged

Optional TreeItem Checkbox #158250

merged 16 commits into from
Sep 6, 2022

Conversation

benibenj
Copy link
Contributor

No description provided.

@benibenj benibenj modified the milestones: August 2022, September 2022 Aug 22, 2022
@benibenj benibenj marked this pull request as ready for review September 2, 2022 12:38
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very good!

src/vs/workbench/browser/checkbox.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/checkbox.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/checkbox.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/checkbox.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/checkbox.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/views/treeView.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/views/treeView.ts Outdated Show resolved Hide resolved
alexr00
alexr00 previously approved these changes Sep 5, 2022
alexr00
alexr00 previously approved these changes Sep 5, 2022
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge despite my comment!

@benibenj benibenj merged commit f51258b into main Sep 6, 2022
@benibenj benibenj deleted the benibenj/treeItemCheckbox branch September 6, 2022 10:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow TreeItems to have optional checkboxes
3 participants