-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git Diff Doesn't Show Changes in New Line Characters #19254
Comments
It was never implemented, thus marking as feature request |
If .git/config has "autocrlf = false" and try to commit file with other new line symbol, VSCode diff viewer show that file was changed but no changes in the file. In same time |
It would be nice to easily change the eol in the git diff view via selecting it in the button on the bottom. |
See my issue mentioning this. The Stage Selected ranged option changes line endings which without diff showing line-ending changes makes it a hard issue to spot ahead of realising gitblame is saying you edited every single line in a file you barely edited. |
I also reccomend using "Render Line Ending" extension to better see when this issue happens, but it still wont make it register as a change in the diff. |
In #5118 (comment) it was suggested to merge that issue #5118 with this issue.
Current title of that issue is: "Diff editor: Show encoding and eol differences" This issue is not about showing encoding changes in the diff editor. The other issue is. Please change this issue title that it includes encoding changes. I can understand if the original author of this issue does not want to change it. Then in future it would be good to ask for change before merging issue with different contents. Original issue is locked - I cannot put this statement there. Creating a new issue would be an option. I'll do that if this issue is not changed. |
We have repos with mixed line endings and not being able to see when I'm about to break a file with line endings changing isn't possible in vscode. I have to use git diff in command line. It would be very helpful to see a solution to this. |
@skl131313 can you change the title in a way that it includes encoding differences? |
Just an update since some time has passed without a fix. others in my company that use pycharm dont have this problem - its pretty hard for me to sell others on vscode when I keep accidentally committing changes that overwrite the entire git blame for a file - because the viewer suppresses the actual delta for all the changes in line endings. I'd really like to see a fix for this point of embarrassment. |
The diffeditor doesn't show new line ending changes (eg CRLF vs LF) even with "diffEditor.ignoreTrimWhitespace" set to false.
The text was updated successfully, but these errors were encountered: