Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff editor: Show encoding and eol differences #5118

Closed
espresso3389 opened this issue Apr 9, 2016 · 3 comments
Closed

Diff editor: Show encoding and eol differences #5118

espresso3389 opened this issue Apr 9, 2016 · 3 comments
Labels
diff-editor Diff editor issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Milestone
Backlog

Comments

@espresso3389
Copy link

  • VSCode Version:
    0.10.14-insider 17fa1cb
  • OS Version:
    Windows 10 x64
    Steps to Reproduce:

Diff files which changes BOM existence and/or line-feed type (CR,LF,CRLF).
The diff view shows us the files are different but we actually see no difference.

I think there should be two status bars (area?) to indicate BOM existences and line-feed types for both versions.
@egamma egamma added feature-request Request for new features or functionality git GIT issues labels Apr 11, 2016
@egamma
Copy link
Member

egamma commented Apr 11, 2016

fyi @joaomoreno

@joaomoreno joaomoreno mentioned this issue Oct 2, 2017
Closed
@sguillia
Copy link

sguillia commented Sep 4, 2018

It would be an enhancement to be able to toggle between "Show CRLF / LF differences in diff view" and "Don't show them".

But I love the feature that allows to ignore line-feed diffs - please keep it.

Note that line feeds may be heterogeneous: a same file can have both LF and CRLF.

@joaomoreno joaomoreno added this to the Backlog milestone Sep 5, 2018
@joaomoreno joaomoreno added diff-editor Diff editor issues and removed git GIT issues labels Sep 17, 2018
@joaomoreno joaomoreno changed the title Git diff does not show BOM/Line-feed differences Diff editor: Show BOM/Line-feed differences Sep 17, 2018
@joaomoreno joaomoreno changed the title Diff editor: Show BOM/Line-feed differences Diff editor: Show encoding and line feed differences Sep 17, 2018
@joaomoreno joaomoreno changed the title Diff editor: Show encoding and line feed differences Diff editor: Show encoding and eol differences Sep 17, 2018
@bpasero bpasero mentioned this issue Sep 21, 2018
Closed
@alexdima
Copy link
Member

Let's continue tracking in #19254 because that one has more upvotes.

@alexdima alexdima added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 22, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
diff-editor Diff editor issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@joaomoreno @egamma @espresso3389 @alexdima @sguillia