Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting a terminal in an aux window doesn't work #195595

Closed
Tyriar opened this issue Oct 13, 2023 · 2 comments · Fixed by #195598
Closed

Splitting a terminal in an aux window doesn't work #195595

Tyriar opened this issue Oct 13, 2023 · 2 comments · Fixed by #195598
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded workbench-auxwindow Issues related to use of auxiliary ("floating") windows.
Milestone
October 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 13, 2023

Image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues workbench-auxwindow Issues related to use of auxiliary ("floating") windows. labels Oct 13, 2023
@Tyriar Tyriar added this to the October 2023 milestone Oct 13, 2023
@Tyriar Tyriar self-assigned this Oct 13, 2023
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 13, 2023
@Tyriar
Expose a documentOverride setting
41c6228 
This lets the embedder choose which Document object to use for creating
elements, adding event listeners, etc. The reason this exists is because
when working with multiple windows it can be convenient to create all
elements under the primary window to make instanceof usage consistent.

See microsoft/vscode#195595
@Tyriar Tyriar mentioned this issue Oct 13, 2023
Merged
@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed labels Oct 13, 2023
Tyriar added a commit that referenced this issue Oct 13, 2023
@Tyriar
Adopt documentOverride in xterm.js
b40a630 
Fixes #195595
@Tyriar Tyriar mentioned this issue Oct 13, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 16, 2023
Alex0007 pushed a commit to Alex0007/vscode that referenced this issue Oct 26, 2023
@Tyriar @Alex0007
Adopt documentOverride in xterm.js
5a2c44a 
Fixes microsoft#195595
@alexr00
Copy link
Member

alexr00 commented Oct 26, 2023

How do I enable terminal in an auxiliary window?

@alexr00 alexr00 added the verification-steps-needed Steps to verify are needed for verification label Oct 26, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Oct 26, 2023

  1. Create new terminal in editor area
  2. Move active editor into new window (experimental)

@Tyriar Tyriar added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Oct 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded workbench-auxwindow Issues related to use of auxiliary ("floating") windows.
Projects
None yet
Milestone
October 2023
Development

Successfully merging a pull request may close this issue.

Adopt documentOverride in xterm.js microsoft/vscode
4 participants
@Tyriar @alexr00 @vscodenpa and others