Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a documentOverride setting #4844

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Oct 13, 2023

This lets the embedder choose which Document object to use for creating elements, adding event listeners, etc. The reason this exists is because when working with multiple windows it can be convenient to create all elements under the primary window to make instanceof usage consistent.

See microsoft/vscode#195595

This lets the embedder choose which Document object to use for creating
elements, adding event listeners, etc. The reason this exists is because
when working with multiple windows it can be convenient to create all
elements under the primary window to make instanceof usage consistent.

See microsoft/vscode#195595
@Tyriar Tyriar added this to the 5.4.0 milestone Oct 13, 2023
@Tyriar Tyriar self-assigned this Oct 13, 2023
@Tyriar Tyriar enabled auto-merge October 13, 2023 20:42
@Tyriar Tyriar merged commit 4245283 into xtermjs:master Oct 13, 2023
18 checks passed
@Tyriar Tyriar deleted the doc_override branch October 13, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant