Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal link provider-based links preview #95081

Closed
10 of 14 tasks
Tyriar opened this issue Apr 13, 2020 · 4 comments
Closed
10 of 14 tasks

Terminal link provider-based links preview #95081

Tyriar opened this issue Apr 13, 2020 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan terminal General terminal issues that don't fall under another label terminal-links
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 13, 2020

You can try out this feature in Insiders by enabling this setting:

image


The link provider experimental API in xterm.js has been merged in with xtermjs/xterm.js#2530 and adopted in VS Code with #90336. I improved it further by adding validated local links (closes the gap with the old system) and "word" links which is the fallback that created words links based on the wordSeparators setting that open quick access.

This issue tracks removal of the old link matcher code, promoting the link provider to default and cleaning up the rough edges.

The plan for April is to get this in a reasonable/preview state, which is already is pretty much. Then for May polish and invest in exposing an API to extensions #91290

@Tyriar Tyriar added plan-item VS Code - planned item for upcoming terminal General terminal issues that don't fall under another label terminal-links labels Apr 13, 2020
@Tyriar Tyriar added this to the On Deck milestone Apr 13, 2020
@Tyriar Tyriar self-assigned this Apr 13, 2020
@Tyriar Tyriar modified the milestones: On Deck, April 2020 Apr 14, 2020
Tyriar added a commit that referenced this issue Apr 17, 2020
This also no longer dismisses the hover when terminal output occurs, this
was over zealous anyway. The actual bug it was trying to fix it tracked
in #95081
@kelleyma49
Copy link

Great stuff! Will it navigation via the keyboard?

This might be overkill, but the ability to use something like jumpy (https://github.com/wmaurer/vscode-jumpy) to follow links would be nice.

@Tyriar
Copy link
Member Author

Tyriar commented Apr 17, 2020

@kelleyma49 currently not, but xtermjs/xterm.js#2848 could make it easier to do that. It would be cool to be able to navigate to the most recently output link and before that, definitely something that should be considered before it's no longer a preview. Created #95570

For jumpy support it would need a whole bunch of APIs which don't exist so that's out of scope but may be possible one day.

@kelleyma49
Copy link

Agreed! Thanks for creating the new issue. Subscribed!

@Tyriar Tyriar changed the title Remove link matcher terminal links Terminal link provider-based links preview Apr 27, 2020
@Tyriar Tyriar added feature-request Request for new features or functionality and removed plan-item VS Code - planned item for upcoming labels Apr 27, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Apr 27, 2020

Closing off for April, May's work is tracked in #96266

@Tyriar Tyriar closed this as completed Apr 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan terminal General terminal issues that don't fall under another label terminal-links
Projects
None yet
Development

No branches or pull requests

2 participants