Link provider probably needs to change to provide links for entire line

[Tyriar]

Consider the following:

Currently in VS Code, depending on which cell you focus first gives a different link.

Good (validated local link provider):

Bad (word link provider):

fyi @jmbockhorst

[jmbockhorst]

So it would look something like this?

provideLink(bufferLineNumber: number, callback: (link: ILink | undefined) => void): void;

[Tyriar]

Yes but multiple returned:

provideLinks(bufferLineNumber: number, callback: (links: ILink[] | undefined) => void): void;

Also when I was looking into #2849 I noticed that right now in vscode we're using leave like a dispose, which is good as xterm drops the link reference when leaving the cell range. But if we did this with the provideLinks idea then we would want to differentiate leave?(event: MouseEvent, text: string): void; and dispose?(): void so xterm owns the decision of when to get rid of it (leave = it may get reused, dispose = embedder should drop the ref).

[Tyriar]

I don't really see another way of fixing this problem of competing providers creating different links based on which cell is hovered first, which leads to an inconsistent experience.

[Tyriar]

This isn't actually fixed yet, we need to delete links that are "below" higher priority links still.