Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer remains faded after clicking on Collapse Folders action while editing new file/folder #96198

Closed
jeanp413 opened this issue Apr 26, 2020 · 1 comment
Closed

Explorer remains faded after clicking on Collapse Folders action while editing new file/folder #96198

jeanp413 opened this issue Apr 26, 2020 · 1 comment
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone
April 2020

Comments

@jeanp413
Copy link
Contributor

  • VSCode Version: From sources

Steps to Reproduce:

  1. Open folder in vscode
  2. Open explorer, select a folder and click on New File/New folder action
  3. Click on Collapse Folders in Explorer Action
  4. 🐛 Explorer remains faded
@isidorn isidorn added the file-explorer Explorer widget issues label Apr 27, 2020
@microsoft microsoft deleted a comment from vscodebot bot Apr 27, 2020
@isidorn
Copy link
Contributor

isidorn commented Apr 27, 2020

Deja vu!
Great catch, had to remove the code you added to prevent this from happening due to my refactoring.
Now just changed the collapse to make sure to remove the edited element.

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Apr 27, 2020
@isidorn isidorn added this to the April 2020 milestone Apr 27, 2020
leilapearson pushed a commit to relmify/vscode that referenced this issue Apr 27, 2020
@isidorn @leilapearson
explorer: If there is something being edited via input box make sure …
17787b1 
…to close it

fixes microsoft#96198
@jrieken jrieken added the verified Verification succeeded label Apr 28, 2020
@jeanp413 jeanp413 mentioned this issue May 3, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
3 participants
@jrieken @isidorn @jeanp413