New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty item in explorer after clicking on Collapse Folders action while editing new file/folder #96853

Merged

isidorn merged 1 commit into microsoft:master from jeanp413:fix-96846

May 4, 2020

Contributor

jeanp413 commented May 3, 2020 •

edited

Loading

This PR fixes #96846

Call this.tree.domFocus in the collapseAll method only if we are editing the explorer to cancel it.
Add a cancelEditing (default true) parameter to the refresh method, the only place we don't want to cancel edit while refreshing is in the setEditable method. With this change the timeout in explorerViewer is not necessary.

Tested this locally on Ubuntu 18.04 on #96846, #96198, #96566


          Focus on explorer tree to cancel editing. Fixes microsoft#96846

67599c7

alexr00 assigned isidorn

Contributor

isidorn commented May 4, 2020

Tried it out and it looks great. Also awesome that you removed the timeout!
Thanks a lot for improving the explorer ☀️

isidorn merged commit bddccf8 into microsoft:master

isidorn added this to the May 2020 milestone

jeanp413 deleted the fix-96846 branch

May 4, 2020 14:58

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet