Allow for reindenting only selected text #35594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I and my friend are waiting this PR. |
|
@nolanpro sorry for responding too late. Do you mind rebasing against latest code and then our test suites can pass? The code looks good to me, once all checks are good let's merge it! |
nolanpro
force-pushed
the
master
branch
5 times, most recently
from
f0e6af1
to
1904cb8
Compare
|
@rebornix Ok rebased and tests passing. Thanks! |
|
@rebornix rebased again just now |
|
@rebornix I am waiting this PR too !!! |
|
+1 |
|
Any news? |
rebornix
reviewed
Apr 17, 2018
| if (selection.isEmpty()) { continue; } | ||
| selections.push(selection); | ||
| } | ||
|
|
There was a problem hiding this comment.
We don't need two for loops here, let's merge them into one.
|
I think this PR is no longer needed. Because of #47116. |
|
Yup, closing in favor of #47116 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from, #28658. Particularly #28658 (comment)
@rebornix This would be very helpful for me and it looks like selection is already supported for
getReindentEditOperations, it just needed to be wired up.