Adding [Reindent Selected Lines] command. #47116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
added 2 commits
April 3, 2018 12:51
|
@roblourens @rebornix What can I do to merge this pull request? |
rebornix
reviewed
Apr 17, 2018
| } | ||
| } | ||
|
|
||
| if (edits) { |
There was a problem hiding this comment.
edits is an array so this condition is always true, let's check its length.
rebornix
reviewed
Apr 17, 2018
| startLineNumber--; | ||
| } | ||
| let editOperations = getReindentEditOperations(model, startLineNumber, endLineNumber) || []; | ||
| for (let editOp of editOperations) { |
There was a problem hiding this comment.
maybe edits.push(...editOperations) is good enough.
|
@malt03 just two tiny recommendations, let's fix them and then merge. |
|
@rebornix Thank you a lot!! |
|
@rebornix When will this be merged? |
|
@malt03 didn't find time to review my issues/prs last week. Merged it now, you can see it from Friday's Insdiers build and Stable release for May. Sorry that I didn't make it in April release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR will add a command named 'Reindent Selected Lines'.
#19847
#28658 (comment)
Screenshot
Note