-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce windows-core
crate
#2475
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds the
windows-core
crate that takes the foundational support in thewindows
crate'score
module and splits it out into a dedicated crate so that it may be used without the heftywindows
crate, if needed.The
windows-core
crate also ditches the hand-rolled internal bindings and instead depends on standalone bindings generated by thewindows-bindgen
crate.The
windows-bindgen
crate’s standalone code generation has been upgraded to support generating bindings for COM and WinRT APIs as well. Thestandalone_sys
function will generatewindows-sys
style bindings while thestandalone_win
function will generatewindows
style bindings. The latter fully supports COM and WinRT types.Developers using the
windows-sys
crate are unaffected by this update as it does not depend on thewindows-core
crate and continues to be the recommended approach for raw bindings to the C-style Windows APIs.Developers using the
windows
crate are mostly unaffected by this update as a dependency on thewindows-core
crate is automatically added. However, if you depend on the component authoring support, you will need to add a dependency to thewindows-core
crate yourself since thewindows-bindgen
crate generates code that only depends on thewindows-core
crate to avoid a circular dependency.This update further addresses feedback from #1720.