Collect all typedefs with same name #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution - good catch. As a reminder, in future please open an issue with a minimal repro before creating a PR. That just makes it easier for me to isolate and identify the necessary change and track a fix. |
kennykerr
reviewed
May 9, 2023
kennykerr
reviewed
May 9, 2023
kennykerr
reviewed
May 9, 2023
|
Looks like you're hitting some new rustup changes. I'll quickly get those addressed in a separate PR to get this unblocked. |
|
Apologies, I had to step away for 2 days - I have now completed #2497 so you should be able to merge master and get this PR building. |
kennykerr
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced in #2475 where all typedefs with the same name are not collected if they aren't explicitly requested by the user.
Let's take
Windows.Win32.System.Diagnostics.Debug.RtlCaptureContextas an example.If we request standalone generation of this function, the code in
standalone_impwill find the function, iterate through its parameters, and collect theCONTEXTtypedef, however, it will only collect the first one that it finds, which is theaarch64version in this particular case, causing thex86andx86_64CONTEXTtypedefs (and their unique nested/referenced typedefs) to not be collected. Previously this worked in 0.49.0 because the top level type collection code usedsignature_cfgto gather all of the parameter/return types.Resolves: #2496