Update readme.md #651
Closed
Update readme.md #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tim-weis
reviewed
Mar 28, 2021
| windows::win32::windows_and_messaging::{MessageBoxA, HWND, MB_FLAGS}, | ||
| windows::data::xml::dom::*, | ||
| windows::win32::system_services::{ | ||
| CreateEventW, SetEvent, WaitForSingleObject, PWSTR |
There was a problem hiding this comment.
This is undoing the changes needed as a result of this pull request.
There was a problem hiding this comment.
The current README examples don't work with the latest version on cargo.
There was a problem hiding this comment.
Correct. But they do work with the latest version on the master branch. This is what's going to go into the next revision, and the README has been updated to reflect that already. That's the reason why all the tests are failing.
There was a problem hiding this comment.
Any timeline for a new crate release?
There was a problem hiding this comment.
Usually once a week. Probably on Monday.
tim-weis
reviewed
Mar 28, 2021
| windows::data::xml::dom::*, | ||
| windows::win32::system_services::{CreateEventW, SetEvent, WaitForSingleObject, PWSTR}, | ||
| windows::win32::windows_and_messaging::{MessageBoxA, HWND, MB_FLAGS}, | ||
| windows::win32::windows_programming::CloseHandle, |
There was a problem hiding this comment.
Same here (see this pull request).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Rust 1.50 and latest version of crate.