Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme.md #651

Closed
wants to merge 1 commit into from
Closed

Update readme.md #651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ This will allow Cargo to download, build, and cache Windows support as a package
```rust
fn main() {
windows::build!(
Windows::Win32::WindowsProgramming::CloseHandle,
Windows::Win32::WindowsAndMessaging::MessageBoxA,
Windows::Data::Xml::Dom::*,
Windows::Win32::SystemServices::{
CreateEventW, SetEvent, WaitForSingleObject
windows::win32::windows_programming::CloseHandle,
windows::win32::windows_and_messaging::{MessageBoxA, HWND, MB_FLAGS},
windows::data::xml::dom::*,
windows::win32::system_services::{
CreateEventW, SetEvent, WaitForSingleObject, PWSTR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is undoing the changes needed as a result of this pull request.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current README examples don't work with the latest version on cargo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. But they do work with the latest version on the master branch. This is what's going to go into the next revision, and the README has been updated to reflect that already. That's the reason why all the tests are failing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any timeline for a new crate release?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually once a week. Probably on Monday.

},
);
}
Expand All @@ -45,12 +45,10 @@ mod bindings {
}

use bindings::{
Windows::Win32::WindowsProgramming::CloseHandle,
Windows::Win32::WindowsAndMessaging::MessageBoxA,
Windows::Data::Xml::Dom::*,
Windows::Win32::SystemServices::{
CreateEventW, SetEvent, WaitForSingleObject
},
windows::data::xml::dom::*,
windows::win32::system_services::{CreateEventW, SetEvent, WaitForSingleObject, PWSTR},
windows::win32::windows_and_messaging::{MessageBoxA, HWND, MB_FLAGS},
windows::win32::windows_programming::CloseHandle,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here (see this pull request).

};

fn main() -> windows::Result<()> {
Expand All @@ -68,7 +66,7 @@ fn main() -> windows::Result<()> {
WaitForSingleObject(event, 0);
CloseHandle(event).ok()?;

MessageBoxA(HWND(0), "Text", "Caption", 0);
MessageBoxA(HWND(0), "Text", "Caption", MB_FLAGS::MB_OK);
}

Ok(())
Expand Down