feat: add targeted communication with the yazi instance (opt-in) #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a technical change with no change in features for the end user. Right now you can opt in to trying it out by setting `use_yazi_client_id_flag = true` in your config (run `:checkhealth yazi` afterwards). This will probably be the default mode of communication in the future. Before this change, real time communication with the embedded yazi instance has been possible, but it has had some limitations: - yazi.nvim had the possibility of sending commands to yazi, but the communication has been global, meaning that all yazi instances running on the system have been able to receive these messages. This has been too dangerous to implement, as making yazi do any actions could have unintended side effects if multiple yazis execute the same actions, potentially in different directories on the system. - similarly, receiving events from yazi has been limited to receiving events from all yazis running on the system. This has not been a problem so far since the events we use (rename, delete, trash, move, cd, hover, bulk) are not dangerous, and typically the user only focuses on one yazi.nvim instance at a time anyway. This change removes this limitation from future features by giving the yazi instance shown by this plugin a unique identifier. This identifier can later be used to send and receive messages with this specific yazi instance. See these for more information and context: - sxyazi/yazi#989 (comment) - sxyazi/yazi#1305
mikavilpas
added a commit
to mikavilpas/dotfiles
that referenced
this pull request
Jul 19, 2024
mikavilpas
added a commit
that referenced
this pull request
Jul 19, 2024
There was a bug in opting in to the feature from 8114817 (feat: add targeted communication with the yazi instance (opt-in) (#225)). Even if you had not set `use_yazi_client_id_flag = true` in your config, the newest yazi was still required. This commit fixes that bug by removing the passing of the `yazi_id` (roll forward style). Later changes can still utilize the feature and build on top of this.
mikavilpas
added a commit
that referenced
this pull request
Jul 19, 2024
There was a bug in opting in to the feature from 8114817 (feat: add targeted communication with the yazi instance (opt-in) (#225)). Even if you had not set `use_yazi_client_id_flag = true` in your config, the newest yazi was still required. This commit fixes that bug by removing the passing of the `yazi_id` (roll forward style). Later changes can still utilize the feature and build on top of this.
mikavilpas
added a commit
that referenced
this pull request
Jul 19, 2024
There was a bug in opting in to the feature from 8114817 (feat: add targeted communication with the yazi instance (opt-in) (#225)). Even if you had not set `use_yazi_client_id_flag = true` in your config, the newest yazi was still required. This commit fixes that bug by removing the passing of the `yazi_id` (roll forward style). Later changes can still utilize the feature and build on top of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a technical change with no change in features for the end user. Right now you can opt in to trying it out by setting
use_yazi_client_id_flag = truein your config (run:checkhealth yaziafterwards).This will probably be the default mode of communication in the future.
Before this change, real time communication with the embedded yazi instance has been possible, but it has had some limitations:
This change removes this limitation from future features by giving the yazi instance shown by this plugin a unique identifier. This identifier can later be used to send and receive messages with this specific yazi instance.
See these for more information and context:
YAZI_IDas a command line argument sxyazi/yazi#1305