fix: crash without newest yazi #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in opting in to the feature from 8114817 (feat: add targeted communication with the yazi instance (opt-in) (#225)). Even if you had not set `use_yazi_client_id_flag = true` in your config, the newest yazi was still required. This commit fixes that bug by removing the passing of the `yazi_id` (roll forward style). Later changes can still utilize the feature and build on top of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in opting in to the feature from 8114817 (feat: add targeted communication with the yazi instance (opt-in) (#225)). Even if you had not set
use_yazi_client_id_flag = truein your config, the newest yazi was still required.This commit fixes that bug by removing the passing of the
yazi_id(roll forward style). Later changes can still utilize the feature and build on top of this.