feat($uiViewScroll): change function to return promise

return the promise from the timeout for additional processing Closes angular-ui#1702
mikef438 · Jan 22, 2015 · c2a9a31 · c2a9a31
1 parent d9c3a95
commit c2a9a31
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/viewScroll.js b/src/viewScroll.js
@@ -42,7 +42,7 @@ function $ViewScrollProvider() {
     }
 
     return function ($element) {
-      $timeout(function () {
+      return $timeout(function () {
         $element[0].scrollIntoView();
       }, 0, false);
     };

diff --git a/test/viewScrollSpec.js b/test/viewScrollSpec.js
@@ -17,6 +17,14 @@ describe('uiView', function () {
       $timeout.flush();
       expect(elem[0].scrollIntoView).toHaveBeenCalled();
     }));
+
+	  it('should return the promise from the timeout', inject(function ($uiViewScroll, $timeout) {
+		  var promise = $uiViewScroll(elem);
+
+		  $timeout.flush();
+		  expect(elem[0].scrollIntoView).toHaveBeenCalled();
+		  expect(promise).toBeDefined();
+	  }));
   });
 
   describe('useAnchorScroll', function () {