Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: support fp16/bf16 vector #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat!: support fp16/bf16 vector #89

wants to merge 1 commit into from

Conversation

jiangyinzuo
Copy link

@jiangyinzuo jiangyinzuo commented Dec 4, 2024 •
edited
Loading

Depends on half crate.

Add fp32/fp64/fp16/bf16 Vec conversion.

BREAKING CHANGES:

  • FieldColumn::new() -> FieldColumn -> FieldColumn::new() -> Result<FieldColumn>
    • add type checking so it may return Error

issue: milvus-io/milvus#37448

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiangyinzuo
To complete the pull request process, please assign yah01 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yah01 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Collaborator

Welcome @jiangyinzuo! It looks like this is your first PR to milvus-io/milvus-sdk-rust 🎉

@mergify mergify bot added the dco-passed label Dec 4, 2024
@jiangyinzuo jiangyinzuo changed the title feat: support fp16/bf16 vector [DO NOT MERGE] feat: support fp16/bf16 vector Dec 4, 2024
@jiangyinzuo jiangyinzuo force-pushed the feat/fp16-bf16 branch 2 times, most recently from 0638758 to b9f4f8c Compare December 5, 2024 05:48
@jiangyinzuo jiangyinzuo changed the title [DO NOT MERGE] feat: support fp16/bf16 vector feat: support fp16/bf16 vector Dec 5, 2024
@jiangyinzuo jiangyinzuo force-pushed the feat/fp16-bf16 branch 2 times, most recently from 8611da7 to 7ff5957 Compare December 5, 2024 07:22
@jiangyinzuo jiangyinzuo changed the title feat: support fp16/bf16 vector feat!: support fp16/bf16 vector Dec 5, 2024
@chyezh
Copy link

chyezh commented Dec 12, 2024

/lgtm

@sre-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot removed the lgtm label Dec 13, 2024
@jiangyinzuo
Copy link
Author

/lgtm

@sre-ci-robot
Copy link
Collaborator

@jiangyinzuo: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jiangyinzuo jiangyinzuo force-pushed the feat/fp16-bf16 branch 9 times, most recently from 94b52a3 to 17059e2 Compare December 15, 2024 11:01
@jiangyinzuo jiangyinzuo force-pushed the feat/fp16-bf16 branch 2 times, most recently from dc18974 to dc4f991 Compare December 20, 2024 12:55
@jiangyinzuo
feat!: support fp16/bf16 vector
dc4f991 
Depends on [half](https://crates.io/crates/half/) crate.

Add fp32/fp64/fp16/bf16 Vec conversion.

BREAKING CHANGES:

- `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>`
    - add type checking so it may return Error

issue: milvus-io/milvus#37448

Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@yah01 yah01 Awaiting requested review from yah01

Assignees

@chyezh chyezh

Labels
dco-passed size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiangyinzuo @sre-ci-robot @chyezh