-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should we just convert FP32 to fp16 automatically? #37448
Labels
stale
indicates no udpates for 30 days
Comments
/assign @cqy123456 |
I think this definitely makes user's understanding easier |
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 8, 2024
issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 8, 2024
issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 9, 2024
RESTful API has 3 handlers. The API changed are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 9, 2024
RESTful API has 3 handlers. The API changed are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 9, 2024
RESTful API has 3 handlers. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 9, 2024
RESTful API has 3 handlers. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 10, 2024
RESTful API has 3 handlers. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 10, 2024
RESTful API has 3 handlers. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 11, 2024
RESTful API has 3 handlers. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 11, 2024
RESTful API has 3 handlers. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 11, 2024
RESTful API has 3 handlers. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 11, 2024
RESTful API has 3 handlers. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 11, 2024
RESTful API has 3 handlers. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 15, 2024
…Go SDK RESTful API has 3 handlers. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 15, 2024
… Go SDK RESTful API The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search Go SDK - Add new API for fp vector conversions issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 16, 2024
RESTful API. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search module github.com/milvus-io/milvus/pkg: Add `Float32ArrayToBFloat16Bytes()`, `Float32ArrayToFloat16Bytes()` and `Float32ArrayToBytes()`. These method will be used in GoSDK in the future. issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 17, 2024
RESTful API. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search module github.com/milvus-io/milvus/pkg: Add `Float32ArrayToBFloat16Bytes()`, `Float32ArrayToFloat16Bytes()` and `Float32ArrayToBytes()`. These method will be used in GoSDK in the future. issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 17, 2024
RESTful API. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search module github.com/milvus-io/milvus/pkg: Add `Float32ArrayToBFloat16Bytes()`, `Float32ArrayToFloat16Bytes()` and `Float32ArrayToBytes()`. These method will be used in GoSDK in the future. issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 18, 2024
RESTful API. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search We do not modify search API in Handler/HandlerV1 because they do not support fp16/bf16 vectors. Module github.com/milvus-io/milvus/pkg: Add `Float32ArrayToBFloat16Bytes()`, `Float32ArrayToFloat16Bytes()` and `Float32ArrayToBytes()`. These method will be used in GoSDK in the future. issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 18, 2024
RESTful API. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search We do not modify search API in Handler/HandlerV1 because they do not support fp16/bf16 vectors. Module github.com/milvus-io/milvus/pkg: Add `Float32ArrayToBFloat16Bytes()`, `Float32ArrayToFloat16Bytes()` and `Float32ArrayToBytes()`. These method will be used in GoSDK in the future. issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 18, 2024
RESTful API. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search We do not modify search API in Handler/HandlerV1 because they do not support fp16/bf16 vectors. Module github.com/milvus-io/milvus/pkg: Add `Float32ArrayToBFloat16Bytes()`, `Float32ArrayToFloat16Bytes()` and `Float32ArrayToBytes()`. These method will be used in GoSDK in the future. issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 18, 2024
RESTful API. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search We do not modify search API in Handler/HandlerV1 because they do not support fp16/bf16 vectors. Module github.com/milvus-io/milvus/pkg: Add `Float32ArrayToBFloat16Bytes()`, `Float32ArrayToFloat16Bytes()` and `Float32ArrayToBytes()`. These method will be used in GoSDK in the future. issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 18, 2024
RESTful API. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search We do not modify search API in Handler/HandlerV1 because they do not support fp16/bf16 vectors. Module github.com/milvus-io/milvus/pkg: Add `Float32ArrayToBFloat16Bytes()`, `Float32ArrayToFloat16Bytes()` and `Float32ArrayToBytes()`. These method will be used in GoSDK in the future. issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 19, 2024
RESTful API. The influenced API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search We do not modify search API in Handler/HandlerV1 because they do not support fp16/bf16 vectors. Module github.com/milvus-io/milvus/pkg: Add `Float32ArrayToBFloat16Bytes()`, `Float32ArrayToFloat16Bytes()` and `Float32ArrayToBytes()`. These method will be used in GoSDK in the future. issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 21, 2024
Make the Milvus server support the conversion from fp32 to fp16/bf16, so as to facilitate the client users who have difficulties in handling fp16/bf16 conversions. 1. The influenced RESTful API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search We do not modify search API in Handler/HandlerV1 because they do not support fp16/bf16 vectors. 2. Add micro-benchmarks for various vector serialization methods. 3. Module github.com/milvus-io/milvus/pkg. Add `Float32ArrayToBFloat16Bytes()`, `Float32ArrayToFloat16Bytes()` and `Float32ArrayToBytes()`. These method will be used in GoSDK in the future. issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this issue
Nov 21, 2024
Make the Milvus server support the conversion from fp32 to fp16/bf16, so as to facilitate the client users who have difficulties in handling fp16/bf16 conversions. 1. The influenced RESTful API are as follows: - Handler. insert - HandlerV1. insert/upsert - HandlerV2. insert/upsert/search We do not modify search API in Handler/HandlerV1 because they do not support fp16/bf16 vectors. 2. Add micro-benchmarks for various vector serialization methods. 3. Module github.com/milvus-io/milvus/pkg. Add `Float32ArrayToBFloat16Bytes()`, `Float32ArrayToFloat16Bytes()` and `Float32ArrayToBytes()`. These method will be used in GoSDK in the future. issue: milvus-io#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-java
that referenced
this issue
Nov 29, 2024
milvus-sdk-java has already implemented fp32 <-> fp16/bf16 conversion methods, this PR just updates the related example. issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-java
that referenced
this issue
Nov 29, 2024
milvus-sdk-java has already implemented fp32 <-> fp16/bf16 conversion methods, this PR just updates the related example. issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
This was referenced Nov 29, 2024
sre-ci-robot
pushed a commit
to milvus-io/pymilvus
that referenced
this issue
Dec 2, 2024
In the Python ecosystem, users may use basic libraries such as numpy, Pandas, TensorFlow, PyTorch... to process float16/bfloat16 vectors. However, users may have float32 vectors and are not clear about how to handle float16/bfloat16 vectors in pymilvus. Currently, pymilvus supports numpy array as embedding vector inputs. However, numpy itself does not support bfloat16 type. This PR demonstrates the way of converting float arrays in insert/search API. **insert (accept numpy array as input)**: - float32 vector (owned by users) -> float16 vector (input param of insert API). numpy is enough, no more dependency. - float32 vector (owned by users) -> bfloat16 vector (input param of insert API). Depends on `tf.bfloat16`. Pytorch can not convert `torch.bfloat16` to numpy array. **search (the API returns bytes as float16/bfloat16 vector)**: - float16 vector (bytes). User can convert it into numpy array, PyTorch Tensor or TensorFlow Tensor. - bfloat16 vector (bytes). User can convert it into PyTorch Tensor or TensorFlow Tensor. There are many deep learning platforms available in Python, and we can't determine which ecosystem users want. Therefore, this PR doesn't add the method for float vector conversion in pymilvus. References: - numpy/numpy#19808 - pytorch/pytorch#90574 issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
sre-ci-robot
pushed a commit
to milvus-io/milvus-sdk-java
that referenced
this issue
Dec 2, 2024
milvus-sdk-java has already implemented fp32 <-> fp16/bf16 conversion methods, this PR just updates the related example. issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
sre-ci-robot
pushed a commit
to milvus-io/milvus-sdk-java
that referenced
this issue
Dec 2, 2024
milvus-sdk-java has already implemented fp32 <-> fp16/bf16 conversion methods, this PR just updates the related example. issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 4, 2024
issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 4, 2024
BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 5, 2024
BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 5, 2024
Depends on [half](https://crates.io/crates/half/) crate. Add fp32/fp64/fp16/bf16 Vec conversion. BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 5, 2024
Depends on [half](https://crates.io/crates/half/) crate. Add fp32/fp64/fp16/bf16 Vec conversion. BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 13, 2024
Depends on [half](https://crates.io/crates/half/) crate. Add fp32/fp64/fp16/bf16 Vec conversion. BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 13, 2024
Depends on [half](https://crates.io/crates/half/) crate. Add fp32/fp64/fp16/bf16 Vec conversion. BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 13, 2024
Depends on [half](https://crates.io/crates/half/) crate. Add fp32/fp64/fp16/bf16 Vec conversion. BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 13, 2024
Depends on [half](https://crates.io/crates/half/) crate. Add fp32/fp64/fp16/bf16 Vec conversion. BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 13, 2024
Depends on [half](https://crates.io/crates/half/) crate. Add fp32/fp64/fp16/bf16 Vec conversion. BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 13, 2024
Depends on [half](https://crates.io/crates/half/) crate. Add fp32/fp64/fp16/bf16 Vec conversion. BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 13, 2024
Depends on [half](https://crates.io/crates/half/) crate. Add fp32/fp64/fp16/bf16 Vec conversion. BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 15, 2024
Depends on [half](https://crates.io/crates/half/) crate. Add fp32/fp64/fp16/bf16 Vec conversion. BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 15, 2024
Depends on [half](https://crates.io/crates/half/) crate. Add fp32/fp64/fp16/bf16 Vec conversion. BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 15, 2024
Depends on [half](https://crates.io/crates/half/) crate. Add fp32/fp64/fp16/bf16 Vec conversion. BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 16, 2024
Depends on [half](https://crates.io/crates/half/) crate. Add fp32/fp64/fp16/bf16 Vec conversion. BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-cpp
that referenced
this issue
Dec 20, 2024
issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-rust
that referenced
this issue
Dec 20, 2024
Depends on [half](https://crates.io/crates/half/) crate. Add fp32/fp64/fp16/bf16 Vec conversion. BREAKING CHANGES: - `FieldColumn::new() -> FieldColumn` -> `FieldColumn::new() -> Result<FieldColumn>` - add type checking so it may return Error issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
jiangyinzuo
added a commit
to jiangyinzuo/milvus-sdk-cpp
that referenced
this issue
Dec 22, 2024
issue: milvus-io/milvus#37448 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
They define their vector as BF16/FP16 already. and there is no easy way to represent BF16/FP16 on most the languages. If data lose accuracy it's user's choice.
If they want to keep original data they should use Fp32 float + Floa16/BF16 quantazition or int8 quantazation in the future
Originally posted by @xiaofan-luan in #37123 (reply in thread)
The text was updated successfully, but these errors were encountered: