Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support json & array types #23408

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Support json & array types #23408

merged 1 commit into from
Apr 20, 2023

Conversation

jiaoew1991
Copy link
Contributor

@jiaoew1991 jiaoew1991 commented Apr 13, 2023 •
edited by congqixia
Loading

See also #23389
/kind feature

@sre-ci-robot sre-ci-robot added approved size/XXL Denotes a PR that changes 1000+ lines. labels Apr 13, 2023
@jiaoew1991
Copy link
Contributor Author

/hold

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file do-not-merge/hold labels Apr 13, 2023
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Apr 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2023

@jiaoew1991 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2023

@jiaoew1991 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2023

@jiaoew1991, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.

@mergify mergify bot added the needs-rebase label Apr 13, 2023
@jiaoew1991 jiaoew1991 marked this pull request as draft April 13, 2023 06:29
@sre-ci-robot sre-ci-robot added the do-not-merge/work-in-progress Don't merge even CI passed. label Apr 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@yah01
Copy link
Member

yah01 commented Apr 14, 2023

Working on it

@yah01
Copy link
Member

yah01 commented Apr 14, 2023

related #23389

@mergify
Copy link
Contributor

mergify bot commented Apr 14, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

9 similar comments
@mergify
Copy link
Contributor

mergify bot commented Apr 14, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 14, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 14, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 14, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 14, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 16, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 16, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 16, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 16, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@congqixia
Copy link
Contributor

/kind feature

@sre-ci-robot sre-ci-robot added the kind/feature Issues related to feature request from users label Apr 18, 2023
@yah01
Copy link
Member

yah01 commented Apr 19, 2023

rerun ut

@yah01 yah01 force-pushed the array-support1 branch 4 times, most recently from 08dbe49 to 1ac16c1 Compare April 19, 2023 06:33
@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@yah01 yah01 force-pushed the array-support1 branch 6 times, most recently from 938af4e to a2c53e8 Compare April 19, 2023 11:21
@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@yah01 @jiaoew1991
Support json & array types
861cf93 
Signed-off-by: yah01 <yang.cen@zilliz.com>
Co-authored-by: jiaoew1991 <enwei.jiao@zilliz.com>
congqixia
congqixia approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

internal/core/src/segcore/segment_c.cpp Outdated Show resolved Hide resolved
internal/core/src/common/Column.h

namespace milvus::segcore {

#define FIELD_DATA(info, field) (info->scalars().field##_data().data())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused macro

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jiaoew1991

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [congqixia,jiaoew1991]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiaoew1991 jiaoew1991 added ci-passed manual-pass manually set pass before ci-passed labeled labels Apr 20, 2023
@sre-ci-robot sre-ci-robot merged commit 967a97b into milvus-io:master Apr 20, 2023
@yah01 yah01 mentioned this pull request Apr 24, 2023
Merged
This was referenced May 2, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@congqixia congqixia

Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm manual-pass manually set pass before ci-passed labeled size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiaoew1991 @yah01 @congqixia @sre-ci-robot