Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-Pick] Support JSON data type #23839

Merged
merged 1 commit into from
May 9, 2023
Merged

[Cherry-Pick] Support JSON data type #23839

merged 1 commit into from
May 9, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented May 2, 2023 •
edited
Loading

related: #23389
Cherry pick #23408 #23563 #23651 #23644 #23720 #23739

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label May 2, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 2, 2023
@mergify
Copy link
Contributor

mergify bot commented May 2, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 2, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 2, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 2, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 2, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 2, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@yah01 yah01 force-pushed the cp-json branch 2 times, most recently from c81e6e0 to 2ebc4fd Compare May 3, 2023 07:56
@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01 yah01 force-pushed the cp-json branch 2 times, most recently from 249f5df to 90713ad Compare May 3, 2023 14:53
@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 6, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 6, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01 yah01 force-pushed the cp-json branch 2 times, most recently from 6ea9737 to 5a90b22 Compare May 6, 2023 06:51
@mergify
Copy link
Contributor

mergify bot commented May 6, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 6, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 6, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 6, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 6, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Support JSON data type
e277528 
Signed-off-by: yah01 <yang.cen@zilliz.com>
@codecov
Copy link

codecov bot commented May 6, 2023 •
edited
Loading

Codecov Report

Merging #23839 (e277528) into 2.2.0 (6e894ed) will decrease coverage by 0.13%.
The diff coverage is 63.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #23839      +/-   ##
==========================================
- Coverage   80.69%   80.56%   -0.13%     
==========================================
  Files         713      717       +4     
  Lines      101825   102611     +786     
==========================================
+ Hits        82168    82673     +505     
- Misses      16443    16724     +281     
  Partials     3214     3214
Impacted Files Coverage Δ
internal/core/src/common/Types.h 100.00% <ø> (ø)
internal/core/src/query/Utils.h 55.55% <0.00%> (-44.45%) ⬇️
...nternal/core/src/query/generated/ExecExprVisitor.h 100.00% <ø> (ø)
...al/core/src/query/visitors/ExecPlanNodeVisitor.cpp 98.41% <ø> (ø)
internal/core/src/segcore/ConcurrentVector.h 84.12% <ø> (ø)
internal/core/src/segcore/SegmentInterface.cpp 81.92% <ø> (ø)
internal/core/src/segcore/SegmentInterface.h 100.00% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.h 100.00% <ø> (+15.38%) ⬆️
internal/core/src/segcore/Utils.h 100.00% <ø> (ø)
internal/core/src/storage/PayloadWriter.cpp 85.18% <0.00%> (-10.65%) ⬇️
... and 39 more

... and 18 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented May 6, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@xiaofan-luan xiaofan-luan added ci-passed manual-pass manually set pass before ci-passed labeled and removed approved labels May 9, 2023
@xiaofan-luan
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 62cabbf into milvus-io:2.2.0 May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved area/compilation area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. lgtm manual-pass manually set pass before ci-passed labeled size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yah01 @xiaofan-luan @sre-ci-robot