Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide dynamic field for describing collection #24312

Merged
merged 1 commit into from
May 23, 2023

Conversation

xiaocai2333
Copy link
Contributor

@xiaocai2333 xiaocai2333 commented May 23, 2023

/kind improvement

  1. DescribeCollection does not return $meta column.
  2. For insert dynamic data, add a new field data with is_dynamic = true.

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor area/test sig/testing test/integration integration test labels May 23, 2023
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 23, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 23, 2023
@czs007
Copy link
Collaborator

czs007 commented May 23, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaocai2333
Copy link
Contributor Author

rerun ut

Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #24312 (18d54d8) into master (d16e18f) will increase coverage by 0.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24312      +/-   ##
==========================================
+ Coverage   81.85%   82.26%   +0.41%     
==========================================
  Files         769      758      -11     
  Lines      101869    99642    -2227     
==========================================
- Hits        83382    81971    -1411     
+ Misses      15451    14641     -810     
+ Partials     3036     3030       -6     
Impacted Files Coverage Δ
internal/proxy/task.go 85.76% <100.00%> (+0.02%) ⬆️
internal/proxy/task_insert.go 68.88% <100.00%> (+1.78%) ⬆️
internal/proxy/util.go 90.97% <100.00%> (ø)

... and 182 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 23, 2023
@czs007
Copy link
Collaborator

czs007 commented May 23, 2023

/lgtm

@sre-ci-robot sre-ci-robot merged commit 7819a57 into milvus-io:master May 23, 2023
xiaocai2333 added a commit to xiaocai2333/milvus that referenced this pull request May 24, 2023
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request May 24, 2023
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 deleted the hide_dynamic_field branch June 7, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants