Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide dynamic field for describing collection (#24312) #24327

Merged
merged 1 commit into from
May 24, 2023

Conversation

xiaocai2333
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor area/dependency Pull requests that update a dependency file labels May 23, 2023
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 23, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 23, 2023
@mergify
Copy link
Contributor

mergify bot commented May 23, 2023

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 24, 2023

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #24327 (1a48b27) into 2.2.0 (3ddf21b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #24327      +/-   ##
==========================================
+ Coverage   80.80%   80.82%   +0.02%     
==========================================
  Files         759      759              
  Lines      106109   106105       -4     
==========================================
+ Hits        85737    85761      +24     
+ Misses      17051    17026      -25     
+ Partials     3321     3318       -3     
Impacted Files Coverage Δ
internal/proxy/task.go 86.77% <100.00%> (+0.01%) ⬆️
internal/proxy/task_insert.go 71.01% <100.00%> (+0.94%) ⬆️
internal/proxy/util.go 90.32% <100.00%> (ø)

... and 19 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 24, 2023
@czs007
Copy link
Collaborator

czs007 commented May 24, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit cdb023d into milvus-io:2.2.0 May 24, 2023
@xiaocai2333
Copy link
Contributor Author

#24232

@xiaocai2333 xiaocai2333 deleted the hide_dynamic_field-pick-2 branch June 7, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants