Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add autoindex mapping for binary/sparse datatype #33624

Closed
wants to merge 1 commit into from

Conversation

foxspy
Copy link
Collaborator

@foxspy foxspy commented Jun 5, 2024

issue: #22837

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 5, 2024
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jun 5, 2024
Copy link
Contributor

mergify bot commented Jun 5, 2024

@foxspy Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.75%. Comparing base (feeb869) to head (a84d4a2).
Report is 61 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #33624   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files        1018     1018           
  Lines      130708   130768   +60     
=======================================
+ Hits       106860   106914   +54     
- Misses      19816    19828   +12     
+ Partials     4032     4026    -6     
Files Coverage Δ
internal/proxy/task_index.go 80.20% <100.00%> (+0.24%) ⬆️
pkg/util/indexparamcheck/hnsw_checker.go 100.00% <100.00%> (ø)
pkg/util/indexparams/index_params.go 90.43% <100.00%> (+0.09%) ⬆️
pkg/util/paramtable/autoindex_param.go 91.37% <100.00%> (+1.37%) ⬆️

... and 36 files with indirect coverage changes

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: foxspy
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Jun 6, 2024
…pe (#33625)

issue: #22837 
pr: #33624

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
@foxspy foxspy force-pushed the autoindex_bs_support_master branch from 40d2517 to a84d4a2 Compare June 6, 2024 02:37
@mergify mergify bot added dco-passed DCO check passed. ci-passed and removed needs-dco DCO is missing in this pull request. labels Jun 6, 2024
chasingegg pushed a commit to chasingegg/milvus that referenced this pull request Jun 14, 2024
@chasingegg
Copy link
Contributor

deprecated by #33868

@foxspy foxspy closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants