enhance: [cherry-pick] add autoindex mapping for binary/sparse datatype #33625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@foxspy Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
|
@foxspy Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
mergify
bot
added
do-not-merge/missing-related-pr
kind/enhancement
|
@foxspy ut workflow job failed, comment |
|
pr: #33624 |
foxspy
changed the title
foxspy
changed the title
|
/rerun ut |
foxspy
changed the title
foxspy
force-pushed
the
autoindex_bs_support_2_4
branch
2 times, most recently
from
ebe8142
to
982f440
Compare
foxspy
force-pushed
the
autoindex_bs_support_2_4
branch
from
982f440
to
5f7e30f
Compare
Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
foxspy
force-pushed
the
autoindex_bs_support_2_4
branch
from
5f7e30f
to
28b07c5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #33625 +/- ##
==========================================
- Coverage 82.13% 82.12% -0.02%
==========================================
Files 1010 1010
Lines 128566 128564 -2
==========================================
- Hits 105600 105577 -23
- Misses 18983 18995 +12
- Partials 3983 3992 +9
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chasingegg
reviewed
Jun 7, 2024
| p.PrepareParams = ParamItem{ | ||
| Key: "autoIndex.params.prepare", | ||
| Version: "2.3.2", | ||
| } | ||
| p.PrepareParams.Init(base.mgr) | ||
|
|
||
| p.LoadAdaptParams = ParamItem{ | ||
| Key: "autoIndex.params.load", | ||
| Version: "2.4.5", |
There was a problem hiding this comment.
why need load params? prepare is enough?
chasingegg
pushed a commit
to chasingegg/milvus
that referenced
this pull request
Jun 14, 2024
…pe (milvus-io#33625) issue: milvus-io#22837 pr: milvus-io#33624 Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jun 18, 2024
yellow-shine
pushed a commit
to yellow-shine/milvus
that referenced
this pull request
Jul 2, 2024
issue: milvus-io#22837 contain milvus-io#33625 milvus-io#33867 milvus-io#33911 which already merged to 2.4 branch Signed-off-by: chasingegg <chao.gao@zilliz.com> Co-authored-by: foxspy <xianliang.li@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #22837
pr: #33624