Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance:[cherry-pick]Allow hnsw to build sparse #33653

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

cqy123456
Copy link
Contributor

@cqy123456 cqy123456 commented Jun 5, 2024

issue:#22837
related:#33675

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 5, 2024
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jun 5, 2024
Copy link
Contributor

mergify bot commented Jun 5, 2024

@cqy123456 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

Copy link
Contributor

mergify bot commented Jun 5, 2024

@cqy123456 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Jun 5, 2024

@cqy123456

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Jun 5, 2024

@cqy123456 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jun 6, 2024
Copy link
Contributor

mergify bot commented Jun 6, 2024

@cqy123456 ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 6, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456 cqy123456 changed the title use knowhere api to check the conbination of index and data enhence:use knowhere api to check the conbination of index and data Jun 6, 2024
@cqy123456 cqy123456 changed the title enhence:use knowhere api to check the conbination of index and data enhance:use knowhere api to check the conbination of index and data Jun 6, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Jun 6, 2024
Copy link
Contributor

mergify bot commented Jun 6, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456 cqy123456 changed the title enhance:use knowhere api to check the conbination of index and data enhance:[cherry-pick]use knowhere api to check the conbination of index and data Jun 6, 2024
Copy link
Contributor

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file area/internal-api area/test sig/testing test/integration integration test size/XXL Denotes a PR that changes 1000+ lines. and removed lgtm size/XS Denotes a PR that changes 0-9 lines. labels Jun 6, 2024
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jun 6, 2024
Copy link
Contributor

mergify bot commented Jun 6, 2024

@cqy123456 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot removed the dco-passed DCO check passed. label Jun 6, 2024
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Jun 6, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jun 6, 2024
@czs007
Copy link
Collaborator

czs007 commented Jun 6, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.09%. Comparing base (58a7111) to head (a6a6321).
Report is 8 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #33653      +/-   ##
==========================================
- Coverage   82.15%   82.09%   -0.07%     
==========================================
  Files        1010     1010              
  Lines      128564   128634      +70     
==========================================
- Hits       105626   105601      -25     
- Misses      18960    19048      +88     
- Partials     3978     3985       +7     
Files Coverage Δ
pkg/util/indexparamcheck/hnsw_checker.go 100.00% <100.00%> (ø)

... and 37 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 6, 2024
@sre-ci-robot sre-ci-robot merged commit 3562ef8 into milvus-io:2.4 Jun 6, 2024
15 of 24 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jun 12, 2024
issue:#22837
related:#33653

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
issue:milvus-io#22837
related:milvus-io#33653

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/dependency Pull requests that update a dependency file area/internal-api area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XS Denotes a PR that changes 0-9 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants