Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: proxy check hnsw with sparse is legal #33697

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

cqy123456
Copy link
Contributor

issue:#22837
related:#33653

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 6, 2024
@cqy123456
Copy link
Contributor Author

rerun ut

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (f7af323) to head (887eaa9).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33697      +/-   ##
==========================================
- Coverage   80.94%   80.91%   -0.04%     
==========================================
  Files        1058     1058              
  Lines      135119   135177      +58     
==========================================
+ Hits       109377   109383       +6     
- Misses      21555    21614      +59     
+ Partials     4187     4180       -7     
Files Coverage Δ
pkg/util/indexparamcheck/hnsw_checker.go 100.00% <100.00%> (ø)

... and 26 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 12, 2024
Copy link
Contributor

@chasingegg chasingegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@czs007
Copy link
Contributor

czs007 commented Jun 12, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, cqy123456, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit be3559e into milvus-io:master Jun 12, 2024
15 checks passed
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
issue:milvus-io#22837
related:milvus-io#33653

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants