enhance: Handle Float16Vector/BFloat16Vector numpy bulk insert as same as BinaryVector #33760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
|
/lgtm |
cydrain
force-pushed
the
caiyd_update_numpy_bulk_insert
branch
from
3d61477
to
0f62478
Compare
sre-ci-robot
added
area/test
sig/testing
test/integration
cydrain
force-pushed
the
caiyd_update_numpy_bulk_insert
branch
from
0f62478
to
e575c2f
Compare
|
@cydrain ut workflow job failed, comment |
…e as BinaryVector Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
cydrain
force-pushed
the
caiyd_update_numpy_bulk_insert
branch
from
e575c2f
to
d4681f2
Compare
bigsheeper
reviewed
Jun 12, 2024
| @@ -199,6 +199,7 @@ func (s *BulkInsertSuite) run() { | |||
| searchResult, err := c.Proxy.Search(ctx, searchReq) | |||
| s.NoError(err) | |||
| s.Equal(commonpb.ErrorCode_Success, searchResult.GetStatus().GetErrorCode()) | |||
| // s.Equal(nq*topk, len(searchResult.GetResults().GetScores())) | |||
|
/lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33760 +/- ##
==========================================
- Coverage 80.94% 80.89% -0.05%
==========================================
Files 1058 1058
Lines 135119 135166 +47
==========================================
- Hits 109377 109348 -29
- Misses 21555 21629 +74
- Partials 4187 4189 +2
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, cydrain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cydrain
added a commit
to cydrain/milvus
that referenced
this pull request
Jun 12, 2024
…e as BinaryVector (milvus-io#33760) Issue: milvus-io#22837 Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jun 13, 2024
yellow-shine
pushed a commit
to yellow-shine/milvus
that referenced
this pull request
Jul 2, 2024
…e as BinaryVector (milvus-io#33760) Issue: milvus-io#22837 Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #22837