Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Handle Float16Vector/BFloat16Vector numpy bulk insert as same as BinaryVector (#33760) #33788

Merged
merged 1 commit into from
Jun 13, 2024
Merged

enhance: Handle Float16Vector/BFloat16Vector numpy bulk insert as same as BinaryVector (#33760) #33788

merged 1 commit into from
Jun 13, 2024
+9 −21

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Jun 12, 2024 •
edited by congqixia
Loading

pr: #33760
Issue: #22837

@cydrain
enhance: Handle Float16Vector/BFloat16Vector numpy bulk insert as sam…
e5669f1 
…e as BinaryVector (milvus-io#33760)

Issue: milvus-io#22837

Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/M Denotes a PR that changes 30-99 lines. labels Jun 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 12, 2024

@cydrain Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Jun 12, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.19%. Comparing base (ff9bb17) to head (e5669f1).
Report is 7 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #33788      +/-   ##
==========================================
- Coverage   82.22%   82.19%   -0.04%     
==========================================
  Files        1013     1013              
  Lines      129075   129064      -11     
==========================================
- Hits       106135   106079      -56     
- Misses      18940    18981      +41     
- Partials     4000     4004       +4
Files Coverage Δ
internal/util/importutilv2/numpy/field_reader.go 61.05% <100.00%> (+0.02%) ⬆️
tests/integration/util_query.go 84.14% <100.00%> (+1.79%) ⬆️

... and 30 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 12, 2024
@bigsheeper
Copy link
Contributor

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ebd0af1 into milvus-io:2.4 Jun 13, 2024
14 of 15 checks passed
@cydrain cydrain deleted the caiyd_update_milvus24_numpy_bulk_insert branch June 13, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@jiaoew1991 jiaoew1991 Awaiting requested review from jiaoew1991

Assignees

@bigsheeper bigsheeper

Labels
approved area/test dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cydrain @bigsheeper @congqixia @sre-ci-robot