Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] autoindex for multi data type #33867

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

chasingegg
Copy link
Contributor

@chasingegg chasingegg commented Jun 14, 2024

issue: #22837
pr: #33868

  • opensource autoindex support
  • metric type check for different data types
  • autoindex data type for search param

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 14, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Jun 14, 2024
Copy link
Contributor

mergify bot commented Jun 14, 2024

@chasingegg Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Jun 14, 2024
@chasingegg chasingegg changed the title enhance: autoindex for multi data type enhance: [2.4] autoindex for multi data type Jun 14, 2024
Copy link
Contributor

mergify bot commented Jun 14, 2024

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 14, 2024

@chasingegg ut workflow job failed, comment rerun ut can trigger the job again.

@chasingegg
Copy link
Contributor Author

rerun ut

@yanliang567 yanliang567 added this to the 2.4.5 milestone Jun 14, 2024
@czs007
Copy link
Contributor

czs007 commented Jun 14, 2024

/approve
/lgtm

@chasingegg chasingegg force-pushed the autoindex-multi-type branch 2 times, most recently from 43e68cd to c04e48f Compare June 14, 2024 11:39
@liliu-z
Copy link
Member

liliu-z commented Jun 14, 2024

/lgtm

@czs007
Copy link
Contributor

czs007 commented Jun 14, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: chasingegg <chao.gao@zilliz.com>
@sre-ci-robot sre-ci-robot removed the lgtm label Jun 14, 2024
@liliu-z
Copy link
Member

liliu-z commented Jun 14, 2024

/lgtm

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 84.31373% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.26%. Comparing base (62bd51e) to head (d18013c).
Report is 8 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #33867      +/-   ##
==========================================
- Coverage   82.32%   82.26%   -0.06%     
==========================================
  Files        1014     1015       +1     
  Lines      129343   129430      +87     
==========================================
- Hits       106481   106477       -4     
- Misses      18878    18942      +64     
- Partials     3984     4011      +27     
Files Coverage Δ
internal/querynodev2/optimizers/query_hook.go 86.36% <100.00%> (+0.31%) ⬆️
pkg/common/common.go 73.33% <ø> (ø)
...util/indexparamcheck/binary_vector_base_checker.go 100.00% <100.00%> (ø)
.../util/indexparamcheck/float_vector_base_checker.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/hnsw_checker.go 100.00% <100.00%> (ø)
...ndexparamcheck/sparse_float_vector_base_checker.go 57.89% <100.00%> (+21.05%) ⬆️
pkg/util/indexparamcheck/base_checker.go 95.45% <0.00%> (ø)
pkg/util/paramtable/autoindex_param.go 91.59% <91.66%> (+0.21%) ⬆️
internal/proxy/task_index.go 80.50% <76.00%> (-0.43%) ⬇️

... and 44 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 14, 2024
@sre-ci-robot sre-ci-robot merged commit 5fc1370 into milvus-io:2.4 Jun 14, 2024
15 checks passed
@chasingegg chasingegg deleted the autoindex-multi-type branch June 15, 2024 01:00
sre-ci-robot pushed a commit that referenced this pull request Jun 18, 2024
issue: #22837 

contain #33625
#33867
#33911 which already merged to
2.4 branch

Signed-off-by: chasingegg <chao.gao@zilliz.com>
Co-authored-by: foxspy <xianliang.li@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
issue: milvus-io#22837 

contain milvus-io#33625
milvus-io#33867
milvus-io#33911 which already merged to
2.4 branch

Signed-off-by: chasingegg <chao.gao@zilliz.com>
Co-authored-by: foxspy <xianliang.li@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants