feat(pymilvus/settings.py): Load configuration without altering the environment #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @laipz8200! It looks like this is your first PR to milvus-io/pymilvus 🎉 |
…nvironment. Signed-off-by: -LAN- <laipz8200@outlook.com>
laipz8200
force-pushed
the
feat/load-configuration-without-altering-the-environment
branch
from
8fa848a to
4854c64
Compare
XuanYang-cn
requested changes
Jul 25, 2024
Signed-off-by: -LAN- <laipz8200@outlook.com>
laipz8200
force-pushed
the
feat/load-configuration-without-altering-the-environment
branch
from
47f605f to
61bd7ce
Compare
|
/lgtm |
XuanYang-cn
added
the
PR | need to cherry-pick to 2.x
XuanYang-cn
approved these changes
Aug 6, 2024
|
Hello @XuanYang-cn, will this be merged? What should I do? |
dr3s
suggested changes
Aug 16, 2024
|
Requested changes to ensure env vars set in other ways precede ones set in .env |
Signed-off-by: -LAN- <laipz8200@outlook.com>
laipz8200
force-pushed
the
feat/load-configuration-without-altering-the-environment
branch
from
694be0f to
d12b6e5
Compare
dr3s
reviewed
Aug 17, 2024
…s >=1.0.1 and <2.0.0 in pyproject.toml and requirements.txt. Signed-off-by: -LAN- <laipz8200@outlook.com>
dr3s
approved these changes
Aug 17, 2024
|
LGTM! |
|
@XuanYang-cn can you approve again please? The lgtm label was removed. |
|
Hello @XuanYang-cn! Could you please let me know when this change can be merged? Is there anything else I need to do? |
|
Sorry about the late response! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dr3s, laipz8200, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
laipz8200
deleted the
feat/load-configuration-without-altering-the-environment
branch
|
@XuanYang-cn Thank you:) |
hasansustcse13
pushed a commit
to hasansustcse13/pymilvus
that referenced
this pull request
Oct 9, 2024
…nvironment (milvus-io#2192) related milvus-io#2166. This PR will replace `environs` with the more lightweight `python-dotenv`. It can load configuration from the dot env file without altering the system environment. --------- Signed-off-by: -LAN- <laipz8200@outlook.com> Signed-off-by: hasan <hasan@m2sys.com>
XuanYang-cn
added
PR | cherry-picked to 2.x
XuanYang-cn
added a commit
to XuanYang-cn/pymilvus
that referenced
this pull request
Nov 15, 2024
- Added grpc as a valid protocol for uri (milvus-io#2090) - build(deps): bump urllib3 from 1.26.18 to 1.26.19 (milvus-io#2140) - build(deps): bump certifi from 2023.7.22 to 2024.7.4 (milvus-io#2170) - feat(pymilvus/settings.py): Load configuration without altering the environment (milvus-io#2192) - feat: Add compact, get_server_version and flush api (milvus-io#2326) - Fix typo and correct grammar (milvus-io#2333) - Update return type of describe_role to Dict (milvus-io#2337) - enhance: Reorganize the examples (milvus-io#2340) Related: milvus-io#2166, milvus-io#2325, milvus-io#2332 Co-authored-by: Bruno Faria <brunocf@ibm.com> Co-authored-by: Bruno Faria <brunocfnba@gmail.com> Co-authored-by: dependabot[bot] <support@github.com> Co-authored-by: -LAN- <laipz8200@outlook.com> Co-authored-by: zhenshan.cao <zhenshan.cao@zilliz.com> Co-authored-by: NamCaoHai <namch.hust@gmail.com> Co-authored-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn
added a commit
to XuanYang-cn/pymilvus
that referenced
this pull request
Nov 15, 2024
- Added grpc as a valid protocol for uri (milvus-io#2090) - build(deps): bump urllib3 from 1.26.18 to 1.26.19 (milvus-io#2140) - build(deps): bump certifi from 2023.7.22 to 2024.7.4 (milvus-io#2170) - feat(pymilvus/settings.py): Load configuration without altering the environment (milvus-io#2192) - feat: Add compact, get_server_version and flush api (milvus-io#2326) - Fix typo and correct grammar (milvus-io#2333) - Update return type of describe_role to Dict (milvus-io#2337) - enhance: Reorganize the examples (milvus-io#2340) Related: milvus-io#2166, milvus-io#2325, milvus-io#2332 Co-authored-by: Bruno Faria <brunocf@ibm.com> Co-authored-by: Bruno Faria <brunocfnba@gmail.com> Co-authored-by: dependabot[bot] <support@github.com> Co-authored-by: -LAN- <laipz8200@outlook.com> Co-authored-by: zhenshan.cao <zhenshan.cao@zilliz.com> Co-authored-by: NamCaoHai <namch.hust@gmail.com> Co-authored-by: yangxuan <xuan.yang@zilliz.com> Signed-off-by: yangxuan <xuan.yang@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Nov 25, 2024
- Added grpc as a valid protocol for uri (#2090) - build(deps): bump urllib3 from 1.26.18 to 1.26.19 (#2140) - build(deps): bump certifi from 2023.7.22 to 2024.7.4 (#2170) - feat(pymilvus/settings.py): Load configuration without altering the environment (#2192) - feat: Add compact, get_server_version and flush api (#2326) - Fix typo and correct grammar (#2333) - Update return type of describe_role to Dict (#2337) - enhance: Reorganize the examples (#2340) Related: #2166, #2325, #2332 Signed-off-by: yangxuan <xuan.yang@zilliz.com> Co-authored-by: Bruno Faria <brunocfnba@gmail.com> Co-authored-by: Bruno Faria <brunocf@ibm.com> Co-authored-by: dependabot[bot] <support@github.com> Co-authored-by: -LAN- <laipz8200@outlook.com> Co-authored-by: zhenshan.cao <zhenshan.cao@zilliz.com> Co-authored-by: NamCaoHai <namch.hust@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #2166.
This PR will replace
environswith the more lightweightpython-dotenv. It can load configuration from the dot env file without altering the system environment.