Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update return type of describe_role to Dict (#2332) #2337

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Update return type of describe_role to Dict (#2332) #2337

merged 2 commits into from
Nov 8, 2024

Conversation

CaoHaiNam
Copy link
Contributor

related: #2332

@CaoHaiNam
Update return type of describe_role to Dict
cc0bcb3 
Signed-off-by: NamCaoHai <namch.hust@gmail.com>
@mergify mergify bot added the dco-passed label Nov 7, 2024
@CaoHaiNam
style: apply Black linting rules
7729b21 
Signed-off-by: NamCaoHai <namch.hust@gmail.com>
@mergify mergify bot added the ci-passed label Nov 7, 2024
@XuanYang-cn XuanYang-cn added the PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch label Nov 8, 2024
@XuanYang-cn
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CaoHaiNam, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2d58eef into milvus-io:master Nov 8, 2024
11 checks passed
@XuanYang-cn XuanYang-cn added PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x and removed PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch labels Nov 15, 2024
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this pull request Nov 15, 2024
@brunocfnba @laipz8200
@czs007 @CaoHaiNam @XuanYang-cn
Multi cherry picks from master branch
c497eb6 
- Added grpc as a valid protocol for uri (milvus-io#2090)
- build(deps): bump urllib3 from 1.26.18 to 1.26.19 (milvus-io#2140)
- build(deps): bump certifi from 2023.7.22 to 2024.7.4 (milvus-io#2170)
- feat(pymilvus/settings.py): Load configuration without altering the environment (milvus-io#2192)
- feat: Add compact, get_server_version and flush api (milvus-io#2326)
- Fix typo and correct grammar (milvus-io#2333)
- Update return type of describe_role to Dict (milvus-io#2337)
- enhance: Reorganize the examples (milvus-io#2340)

Related: milvus-io#2166, milvus-io#2325, milvus-io#2332

Co-authored-by: Bruno Faria <brunocf@ibm.com>
Co-authored-by: Bruno Faria <brunocfnba@gmail.com>
Co-authored-by: dependabot[bot] <support@github.com>
Co-authored-by: -LAN- <laipz8200@outlook.com>
Co-authored-by: zhenshan.cao <zhenshan.cao@zilliz.com>
Co-authored-by: NamCaoHai <namch.hust@gmail.com>
Co-authored-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn mentioned this pull request Nov 15, 2024
Merged
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this pull request Nov 15, 2024
@brunocfnba @laipz8200
@czs007 @CaoHaiNam @XuanYang-cn
Multi cherry picks from master branch
09dc873 
- Added grpc as a valid protocol for uri (milvus-io#2090)
- build(deps): bump urllib3 from 1.26.18 to 1.26.19 (milvus-io#2140)
- build(deps): bump certifi from 2023.7.22 to 2024.7.4 (milvus-io#2170)
- feat(pymilvus/settings.py): Load configuration without altering the environment (milvus-io#2192)
- feat: Add compact, get_server_version and flush api (milvus-io#2326)
- Fix typo and correct grammar (milvus-io#2333)
- Update return type of describe_role to Dict (milvus-io#2337)
- enhance: Reorganize the examples (milvus-io#2340)

Related: milvus-io#2166, milvus-io#2325, milvus-io#2332

Co-authored-by: Bruno Faria <brunocf@ibm.com>
Co-authored-by: Bruno Faria <brunocfnba@gmail.com>
Co-authored-by: dependabot[bot] <support@github.com>
Co-authored-by: -LAN- <laipz8200@outlook.com>
Co-authored-by: zhenshan.cao <zhenshan.cao@zilliz.com>
Co-authored-by: NamCaoHai <namch.hust@gmail.com>
Co-authored-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Nov 25, 2024
@XuanYang-cn @brunocfnba
@laipz8200 @czs007 @CaoHaiNam
Multi cherry picks from master branch (#2349)
29bef71 
- Added grpc as a valid protocol for uri (#2090)
- build(deps): bump urllib3 from 1.26.18 to 1.26.19 (#2140)
- build(deps): bump certifi from 2023.7.22 to 2024.7.4 (#2170)
- feat(pymilvus/settings.py): Load configuration without altering the
environment (#2192)
- feat: Add compact, get_server_version and flush api (#2326)
- Fix typo and correct grammar (#2333)
- Update return type of describe_role to Dict (#2337)
- enhance: Reorganize the examples (#2340)

Related: #2166, #2325, #2332

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Co-authored-by: Bruno Faria <brunocfnba@gmail.com>
Co-authored-by: Bruno Faria <brunocf@ibm.com>
Co-authored-by: dependabot[bot] <support@github.com>
Co-authored-by: -LAN- <laipz8200@outlook.com>
Co-authored-by: zhenshan.cao <zhenshan.cao@zilliz.com>
Co-authored-by: NamCaoHai <namch.hust@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangting0128 wangting0128 Awaiting requested review from wangting0128

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@XuanYang-cn XuanYang-cn

Labels
approved ci-passed dco-passed lgtm PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CaoHaiNam @XuanYang-cn @sre-ci-robot