-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the github workflow #814
Conversation
@ebozduman can you check this and run? |
I need to ask permission/blessing of the team as they might also have some kind of a plan already in place. I kicked of all the checks but of course, nothing happens as the workflows depend on the new |
@ebozduman I've added master to the script now. This should make it possible to merge now, and wait for the team to agree on the develop and main change. |
@ebozduman can you run again? |
It is stuck again !?!? Is the added master branch gone somehow? Meanwhile,
let's say |
Yeah we can add a framework like that later. The build is not stuck, you just need to run the last commit. |
Started. |
Look at the flow now: https://github.com/minio/minio-dotnet/actions/runs/5738231383 Looks nice with jobs splitting up! Later on I could maybe even bring in more improvements. |
@ebozduman it passed the build! Can you merge now? |
Running again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The build check is waiting for status to be reported for a 6.0 build, which is supposed to be not required anymore. |
How can that be removed? It is not in the new script anymore |
I am also not sure how. Checking... |
@ebozduman I found this: The status "Expected — Waiting for status to be reported" typically appears when a GitHub Actions workflow is expected to run on a commit or pull request, but has not yet reported a status. If the workflow was removed or renamed in the repository, this status might be left "hanging" and the check might become a "stale check." To remove a stale check, you need to update the branch protection rules, if you have the necessary permissions (i.e., you are an owner or administrator of the repository). Here's how to do it: Go to your GitHub repository. Note that only users with admin or owner permissions for the repository can change the branch protection rules. If you don't have the necessary permissions, you'll need to contact someone who does to make the change for you. |
Ok. Great! |
@ebozduman
According to good practice and latest standards there are some things that should change. You need to create a develop and a main branch. The default branch should be develop.
Also a NUGET_API_KEY needs to be added to the secrets