Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize all the line endings #815

Closed
wants to merge 7 commits into from
Closed

Conversation

martijn00
Copy link
Contributor

@ebozduman this seems to finally have done it. Can you merge?

@ebozduman
Copy link
Collaborator

ebozduman commented Aug 2, 2023

@martijn00

This is pure CRLF => LF changes on all files, right?
I guess, we see this exchange PR again, because the development environment used to create the branch was on Windows?

Is this correct in your case?

No matter what though, I thought git will take care of the situation and the data will be always saved in Unix style, so there won't be any need to create an exchange PR again.
Then why are we in the same situation??

@martijn00
Copy link
Contributor Author

@ebozduman I'm trying to figure this out again. Yesterday it worked for me to convert all using find . -type f -exec dos2unix {} \; today it seems all reverted back.

I'm struggling to move forward because this process takes so long and so many PR's need updating every time. Can you merge #814 and create the develop and main branch? Then it is easier to work forward on next PR's.

@ebozduman
Copy link
Collaborator

@martijn00

I'll check PR#814, but I think we need #812 merged to be able to turn off parallel run. Only then we can start seeing successful build tests and merges happening.

@martijn00
Copy link
Contributor Author

@ebozduman Then lets merge 812 and 814 right after. I still doubt if the build runs with formatting on that. But lets move forward first and merge all those PR's and fix the formatting after in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants