Check your claim page changes #2340

lostie · 2018-04-23T16:35:21Z

What

Re-styling the "Check your claim" page and add links to each of the sections so users can edit them directly, rather than having to go step by step until reaching the named section.
When the users are on the claims list page and click on a claim that is in draft the page shown is the "Check your claim" page
The users are not able to save as draft for case details and transfer fee details as their the most basic information that is required in order for the claim to exist in the system. NOTE: This only applies for the web submissions. API submissions remained the same.
In the web submissions, each form step is now validated independently from any other steps. NOTE: This only applies for the web submissions. API submissions remained the same.
DRY form templates. Remove repetition from form templates (first step for this process, that requires further DRYness).
"Check Your Claim" page display a top level banner if the claim is NOT valid and informs the user of which sections still need to be completed.
For each section, if the section cannot be edited, an info banner is displayed informing the user of which other sections need to be completed before being able to edited.
Assigns total attributes for litigator final/interim/transfer claims before validation so that its possible to correctly validate the associated fees total in each of their own steps.

Ticket

Change links on the 'check your claim page'

All the check your page claim was doing was a whole bunch of if/else statements to display sections depending on what type of claim and what kind of information it has. These changes do 2 things: - the sections that are required for a given type of claim are now defined in its associated presenter and the view just iterates over those sections. - if a given section is required for a type of claim but its not to be displayed given some data the claim has, that decision is taken on the template for that section.

The re-styling applies for all kind of fees that make use of the summary_fees template (e.g. fixed fees, basic fees, etc)

page Also: Re-styling of the warrant fee page

- Validate only the fields for the current step - Preserve existent validation behaviour for the API submissions

has_one/has_many validations for web submissions should only be validated if they're associated with the current step.

With the introducion of editing a claim step directly, there will be cases where the fee trying to be displayed in the summary is not yet filled. For those cases, the template for the fee summary should not be rendered as there's no info to display.

lostie · 2018-05-02T09:14:41Z

app/presenters/claim/interim_claim_presenter.rb

@@ -25,15 +25,18 @@ def type_identifier
    'lgfs_interim'
  end

-  def raw_fixed_fees_total


This doesn't seem to be needed for this type of claim.

- If the claim is in draft the edit link opens the "Check your claims page" - If the claim in NOT in draft the edit link opens the "Summary page"

Was left from a previous commit.

The claim page will show 2 new components: - A top level component that applies to the claim, which will be displayed if the claim is not valid to be certified. - A component per section, which will be displayed if that given section requires some other sections to be filled before it can be completed. Also: - Refactored the logic to determine the validity of a claim/section. Moved that logic to services given there was too much complexity to be added directly to the claims model. TODO: There's still quite a lot of DRY work to do, but these changes are becoming to big to be able to address them: - DRY summary pages. There's a lot of repetition in the summary page, specially for the headers/status of the page

(CYC - Check your claim) When a type of fees is being displayed in the CYC page and there's no fees for it, the page displays the appropriate wording instead of an empty list.

Both new/create actions for the certifications controller were changed to have a before hook to assert that the claim is valid and can be certified. If the claim is not valid, the user is redirected to the "Check Your Claim" page and an error message is displayed. Also: - Removed duplicate check on new action for status of claim (was already being done in a before hook) - The new action used to validate the claim based on the current step (at least there's step being step). With the changes introduced to the validations to have them perform in isolation for each step, the certifications would validate ONLY the default step (case details for most of the claims). These changes guarantee that the validation is performed on all the steps of the claim, which should be the only way to proceed to the certification.

Due to the existent validation behaviour some fields, like total were being checked at the very end of the submission. After the changes to validate ONLY each step as required, these field validations need to be performed in the appropriate step where they're actually required.

colinbruce

Looking good...

Manual testing of API testing starts now

colinbruce · 2018-05-08T14:47:16Z

config/locales/en.yml

          summary: 'Note: To best navigate this table, select the right hand column and then step down through the rows.'
-      tranfer_detail:
+      transfer_detail:


What: - Case details are no longer saved as draft as are considered mandatory information. The save as draft functionality is tested on the defendants page instead

The totals (fees, expenses, vat, etc) are now validated in the appropriate steps where they're required. Because in the first instance the fees are not yet persisted during the validations, a 'total amount claimed must be greater than 0' was being displayed. The reason for that is the totals were only being updated after the records were saved. These changes, ensure for non-API submissions (still need to check if the API should follow the same behaviour or not) the totals are set before validation so we can assert they're valid as expected. Also: - Refactored the calculations module to allow collections or single records of fees to be provided for the totals calculation.

CYC - Check Your Claim page - If there’s content for the section, the missing information message should not appear - If there’s no content for the section, only the missing information message should appear

exist

Given the user can only submit the transfer details without case details, the "Check Your Claim" page should show the other sections cannot be filled in without the case details.

Was a URL and was not safe to just pass whatever we received. Now it checks for the referrer param to be passed, and if it is, it maps it into a referrer URL if it matches any valid whitelist referrer.

CYC - Check Your Claim page The rationale behind this change has to do with the fact that these type of fees are currently created blank before hand. To keep this behaviour without impacting the rest of the application, the CYC page does not display any basic fees if they're all blank.

Until now the validation failed even when there wasn't fees set. That was because the check was being made as: total_defendant_uplifts_fees (0) + 1 > number_of_defendants (0) Going forward the validation is performed only when there's at least a fee set.

Given the current submitted data, if a section cannot be accessed (e.g. Travel expenses for LGFS Interim claims should only be accessed if a warrant fee is set), that section should not be displayed.

If not the "Check Your Claim" page will display a message indicating they haven't instead of the list with empty fields.

So that we can decide if the section is displayed or not in the "Check Your Claim" page

lostie added the WIP label Apr 23, 2018

lostie force-pushed the check-your-claim-page-changes branch from 3ce7cf2 to f0a47e9 Compare April 25, 2018 16:04

lostie requested a review from cleargif April 26, 2018 12:48

lostie force-pushed the check-your-claim-page-changes branch 5 times, most recently from 329c161 to 96cbaff Compare May 1, 2018 13:17

Sergio Marques added 17 commits May 2, 2018 09:54

Re-styling of check your claims page

fbc59d6

Add edit links to claim sections in "Check your claim" page

3a175c5

Re-style case details "check your claim" section

ea5bb42

Re-style defendants section in "check your claim" page

2b385f7

Re-styling of graduated/misc fees section in "Check your claim" page

8146ec3

The re-styling applies for all kind of fees that make use of the summary_fees template (e.g. fixed fees, basic fees, etc)

Re-styling of disbursements section in "Check your claim" page

c9d6359

Re-styling expenses section in 'Check your claim' page

bff5948

Re-styling supporting evidence section in "Check your claim" page

ddafa4b

Re-styling of offences section in "Check your claim" page

516a0da

Re-styling of interim fee section in 'Check your claim' page

9089640

Re-styling transfer details section on "Check your claim" page

fef06ba

Different displays for singe fee/fee collection in 'Check your claim'

61d5906

page Also: Re-styling of the warrant fee page

Fix failing features due to changes in claim summary page

fe807d7

Validate fields only for current step

7769da2

- Validate only the fields for the current step - Preserve existent validation behaviour for the API submissions

Validate claim only current step (has_<one|many> validations)

4cd8a9f

has_one/has_many validations for web submissions should only be validated if they're associated with the current step.

lostie force-pushed the check-your-claim-page-changes branch from 96cbaff to 43a48c1 Compare May 2, 2018 09:03

lostie commented May 2, 2018

View reviewed changes

Sergio Marques added 3 commits May 2, 2018 11:47

Conditional link for edit claim in claims page

5f86127

- If the claim is in draft the edit link opens the "Check your claims page" - If the claim in NOT in draft the edit link opens the "Summary page"

Add button to delete draft in "Check your claim" page

3398171

Remove debug code from view

dcf0174

Was left from a previous commit.

lostie requested a review from colinbruce May 8, 2018 11:57

lostie force-pushed the check-your-claim-page-changes branch from e129c17 to 3d89dec Compare May 8, 2018 12:54

Sergio Marques added 5 commits May 8, 2018 13:55

Display appropriate wording when there's no fees in CYC page

cb611e9

(CYC - Check your claim) When a type of fees is being displayed in the CYC page and there's no fees for it, the page displays the appropriate wording instead of an empty list.

Add missing locale for supporting evidence header

65f61e2

colinbruce approved these changes May 8, 2018

View reviewed changes

Sergio Marques added 8 commits May 8, 2018 17:07

Fix failings features

01988a8

What: - Case details are no longer saved as draft as are considered mandatory information. The save as draft functionality is tested on the defendants page instead

Change logic for displaying warning/no details in CYC page

9d272ec

CYC - Check Your Claim page - If there’s content for the section, the missing information message should not appear - If there’s no content for the section, only the missing information message should appear

Default fee calculation to zero if fee does not exist

56f4fb5

Check Your Claim page shows defendants ordered by creation date

8de89e0

Calculate fee total defaults to 0 if fee amount is nil

fbae746

Disk reference number is not set until both claim id and case number

06d5592

exist

Add further dependencies to transfer claim stages

cc822bc

Given the user can only submit the transfer details without case details, the "Check Your Claim" page should show the other sections cannot be filled in without the case details.

lostie force-pushed the check-your-claim-page-changes branch 2 times, most recently from 8783912 to 779c0bb Compare May 10, 2018 08:48

Sergio Marques added 3 commits May 10, 2018 12:24

Change CYC referrer to be a string

8147e57

Was a URL and was not safe to just pass whatever we received. Now it checks for the referrer param to be passed, and if it is, it maps it into a referrer URL if it matches any valid whitelist referrer.

lostie force-pushed the check-your-claim-page-changes branch from 779c0bb to 4563725 Compare May 10, 2018 11:24

Sergio Marques added 3 commits May 10, 2018 13:41

CYC page shows only sections that can be accessed

1415594

Given the current submitted data, if a section cannot be accessed (e.g. Travel expenses for LGFS Interim claims should only be accessed if a warrant fee is set), that section should not be displayed.

Implement logic to determine if case details have been filled

cab0bc5

If not the "Check Your Claim" page will display a message indicating they haven't instead of the list with empty fields.

Implement logic to determine if supporting evidence is filled

40f3c3a

So that we can decide if the section is displayed or not in the "Check Your Claim" page

lostie removed the WIP label May 10, 2018

Minor tweaks to the claim/fee presenters

2dfcbf5

lostie merged commit 5f969e0 into master May 14, 2018

lostie deleted the check-your-claim-page-changes branch May 14, 2018 11:07

lostie mentioned this pull request May 24, 2018

"Check your claim" page fixes #2375

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check your claim page changes #2340

Check your claim page changes #2340

lostie commented Apr 23, 2018 •

edited

Loading

lostie May 2, 2018

colinbruce left a comment

colinbruce May 8, 2018

Check your claim page changes #2340

Check your claim page changes #2340

Conversation

lostie commented Apr 23, 2018 • edited Loading

What

Ticket

lostie May 2, 2018

Choose a reason for hiding this comment

colinbruce left a comment

Choose a reason for hiding this comment

colinbruce May 8, 2018

Choose a reason for hiding this comment

lostie commented Apr 23, 2018 •

edited

Loading